On Tue, 26 Jan 2010, David Brownell wrote: > On Tuesday 26 January 2010, Nicolas Pitre wrote: > > > > > > For the record: I did get that working with an ARM9, no > > > > changes, using the latest CodeSourcery EABI toolchain. > > > > > > > > > > strange, i tested on arm9 aswell. > > > fileio was ok, just printf to stdout/stderr failed. > > > > It is used in production settings here, so if it didn't work on ARM9 I > > would have fixed it long ago. ;-) > > Comments on any other parts of Spen's patches? Not the changes to > make v7M work, but the other semihosting changes.
When do_semihosting() returns with an error, the caller should return right away with 1 as the original code did and not 0 like the patch does. Also I don't like the fact that the introduced arm_semi_hosting structure (which could have been done in a patch of its own btw) is carrying fields that are valid only for one particular instance of a semihosting call and therefore should have been kept local to the implementation rather than growing the arm structure uselessly. Those are "result" and "core_cache". I think that getting r0 and r1 should be abstracted out of do_semihosting() and passed directly by both callers instead, etc. Finally the fix for FLEN could be split in a patch of its own too as this is clearly an orthogonal issue. Nicolas
_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
