On Wed, Feb 24, 2010 at 7:47 PM, Mariano Alvira <[email protected]> wrote:
> On Wed, Feb 24, 2010 at 07:30:31PM +0100, Øyvind Harboe wrote:
>> The target/board config files should be broken out in a separate commit.
>
> Ok. Will do.
>
>>
>> Delete the above lines, they don't belong in the target file.
>
> Thanks.
>
>>
>> > +#jtag_rclk 2000
>>
>> Why is this line commented out?
>
> I haven't had any luck with rclk.
Comment then?
# Really rclk should have worked, but it didn't in testing
# using jtag_khz 2000 instead...
>
>>
>> > +jtag_khz 2000
>>
>>
>>
>> > +set _TARGETNAME [format "%s.cpu" $_CHIPNAME]
>> > +target create $_TARGETNAME arm7tdmi -endian $_ENDIAN -chain-position
>> > $_TARGETNAME -variant arm7tdmi
>> > +#$_TARGETNAME -variant arm7tdmi
>> > +#$_TARGETNAME configure -event reset-init {
>> > +# sleep 100
>> > +# soft_reset_halt
>> > +# mww 0x80000018 0x50000000
>> > +# mww 0x80000000 0x00000f00
>> > +# mww 0x80000008 0x00000e00
>> > +# mww 0x80005000 0x00006013
>> > +# # mww 0x80005018 0x017f270f
>> > +# # mww 0x80005008 0x55
>> > +# mww 0x80005018 0x07A9270F
>> > +# mww 0x80005008 0x55
>> > +# sleep 100
>> > +#}
>>
>> Why are these lines commented out? Should they be deleted?
>
> Yes, they should. This file is mostly the original from Sergie Lapin
> and Jeff Williams --- so I'm not sure what they were trying there but
> it isn't needed.
It's very frustrating to see commented out code when trying to debug
some nasty problem in setup. What did it mean? Should it have
been there? etc. :-)
>
>>
>> +++ b/tcl/board/redbee-econotag.cfg
>> @@ -0,0 +1,5 @@
>> +source [find target/mc13224v.cfg]
>> +
>> +interface ft2232
>> +ft2232_layout redbee-econotag
>> +ft2232_vid_pid 0x0403 0x6010
>>
>> Interface stuff does not belong in the board files. "board" is as in
>> target pcb.
>
> The econotag has an integrated ft2232h on the board. It's hardwired to
> the mc13224v. So in this case I think it does belong. Same with the
> redbee-usb, except it is wired to INTERFACE_B.
I see. A comment then? :-)
--
Øyvind Harboe
Visit us at Embedded World, March 2nd-4th. IS2T's stand, HALL 10 - 118
http://www.zylin.com/events_embeddedworld.html
US toll free 1-866-980-3434 / International +47 51 63 25 00
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development
