On Sunday 28 February 2010, Øyvind Harboe wrote:
> I've fixed some problems in add_tms_seq and added
> support to bitbang & zy1000.

Passing the next state down to the minidriver seems fairly
innocuous, though I'm not sure why it would matter (since
it's already been set in the state follower) ... or what
the minidriver would want to do with it (and why it shouldn't
just use the state follower).

The bitbang (parport!) and zy1000 stuff looks straightforward,
which seems appropriate.



> Not tested yet, ready for comments:
> 
> 
> http://repo.or.cz/w/openocd/oharboe.git/shortlog/refs/heads/addtms

I don't see the point of the ft2232 change:

@@ -1792,6 +1792,10 @@ static int ft2232_execute_tms(struct jtag_command *cmd)
        }
 
        require_send = 1;
+
+       if (tap_get_state() != TAP_INVALID)
+               tap_set_end_state(tap_get_state());
+
        return retval;

The end state should already have been set before this is called...
Plus ... INVALID is used to indicate "it's in SWD now", so I'm not
sure that part would be right either.

- Dave
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to