Hi, in "src/helper/membuf.c" there are several unused functions. I was working at a cleanup, and I noticed: - functions in "membuf.c" just put string messages in a buffer, to be eventually printed later. - such functions are only referenced in "src/flash/nor/at91sam3.c". - buffer is printed in "at91sam3.c" through command_print() or LOG_INFO(). - one of the unused function is the one that free() the buffer. This means in "at91sam3.c" there are buffers that are never freed.
I believe would be better to revisit the file "at91sam3.c" and replace all usage of "membuf.c" with direct prints through command_print() or LOG_INFO(). After that, the whole helper file "membuf.c" could be removed. Any comment? I'm available to make this job, but I have no possibility to test the code, since missing the proper target board. Anyone available to contribute? Best Regards, Antonio Borneo _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
