On Monday 12 April 2010, Antonio Borneo wrote: > Also, no feedback on patch in mail > https://lists.berlios.de/pipermail/openocd-development/2010-March/015222.html >
A good example of why patches-as-attachments are awkward .... I couldn't follow up at all easily, either to your original or to its archived version. If that's what I Think it is .... Ijust merged an updated version. Two comments: (a) it was basically my patch (with (attribution removed) plus a tweak. best to forward entire patches, including such tweaks, for individual review (not combined with othr stuff or as attachments). The reason it took so long to review that is that I had to split out the tweak and review it by itself. ... that was extra work. The tweak got a small update including a FIXME comment. Basically that check was somewhat misplaced, and the better fix would put it in the right place instead of adding extra tests. - Dave _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
