Hi Øyvind,

in ./src/jtag/jtag.h struct jtag_tap_s is defined a field named "hasidcode".
It has been introduced by one of your patches, on Aug 26 2009.
This field is assigned 4 times in ./src/jtag/core.c in function
jtag_examine_chain(), but never used.

What should be the correct development path?
- remove it, since useless,
- keep it, since required for following development,
- there is a bug in the code, since every time the field "idcode" is
used we need to check if it is valid, through "hasidcode" value
?

I'm not sure, but I think that every value of idcode with bit 0 set is invalid.
In such case, another possible change is to define as invalid, e.g.
idcode = 1, and add comment to document this case.

Best Regards,
Antonio Borneo
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to