declaration of ‘index’ shadows a global declaration
in /usr/include/string.h

Signed-off-by: Andreas Fritiofson <andreas.fritiof...@gmail.com>
---
I'm not convinced of the benefit of the warning in this case. A whole bunch
of other warnings or error would catch the bug if the local variable index
had been used in place of the system header declared _function_ index. I had
expected the warning to be emitted only for shadowing of compatible types.
---
 src/jtag/drivers/arm-jtag-ew.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/jtag/drivers/arm-jtag-ew.c b/src/jtag/drivers/arm-jtag-ew.c
index 7a6c178..72c756e 100644
--- a/src/jtag/drivers/arm-jtag-ew.c
+++ b/src/jtag/drivers/arm-jtag-ew.c
@@ -568,29 +568,29 @@ static void armjtagew_tap_ensure_space(int scans, int 
bits)
 static void armjtagew_tap_append_step(int tms, int tdi)
 {
        last_tms = tms;
-       int index = tap_length / 8;
+       int index_local = tap_length / 8;
 
-       if (index < ARMJTAGEW_TAP_BUFFER_SIZE)
+       if (index_local < ARMJTAGEW_TAP_BUFFER_SIZE)
        {
                int bit_index = tap_length % 8;
                uint8_t bit = 1 << bit_index;
 
                if (tms)
                {
-                       tms_buffer[index] |= bit;
+                       tms_buffer[index_local] |= bit;
                }
                else
                {
-                       tms_buffer[index] &= ~bit;
+                       tms_buffer[index_local] &= ~bit;
                }
 
                if (tdi)
                {
-                       tdi_buffer[index] |= bit;
+                       tdi_buffer[index_local] |= bit;
                }
                else
                {
-                       tdi_buffer[index] &= ~bit;
+                       tdi_buffer[index_local] &= ~bit;
                }
 
                tap_length++;
-- 
1.6.3.3

_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to