Hector Oron scrisse:

> I have also been playing with this bug. Just one comment on the
> ep93xx.c
> 
> > -static int ep93xx_register_commands(struct command_context
> > *cmd_ctx); 
> >
> > -       .register_commands = ep93xx_register_commands,
> 
> Why not just use the right value in the struct,
> +       .commands = ep93xx_register_commands,

Because the "commands" field no longer accepts function pointers, 
as in src/jtag/interface.h:229:

/**
  * The interface driver may register additional commands to expose
  * additional features not covered by the standard command set. 
  */
        const struct command_registration *commands;

Moreover, ep93xx_register_commands was just a stub, and looking 
at git history I've seen they're usually removed (eg. in 66ee30).
I hope not to be wrong on this...

Cheers, Luca

-- 
 .''`.  ** Debian GNU/Linux **  | Luca Bruno (kaeso)
: :'  :   The Universal O.S.    | lucab (AT) debian.org
`. `'`                          | GPG Key ID: 3BFB9FB3
  `-     http://www.debian.org  | Debian GNU/Linux Developer

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to