On 11/11/2010, at 6:48 AM, Spencer Oliver wrote: > On 09/11/2010 07:13, Steve Bennett wrote: >> >> On 09/11/2010, at 5:10 PM, Øyvind Harboe wrote: >> >>> On Tue, Nov 9, 2010 at 8:08 AM, Steve Bennett<[email protected]> >>> wrote: >>>> >>>> On 09/11/2010, at 4:59 PM, Øyvind Harboe wrote: >>>> >>>>> Why is " -I$(top_srcdir)/jimtcl \", that doesn't seem right. >>>>> >>>>> Shouldn't it be only the build dir? >>>> >>>> I modelled it on what was already there: >>>> >>>> -I$(top_srcdir)/src \ >>>> -I$(top_builddir)/src >>>> >>>> If you build out of tree, you will need both the static headers >>>> and the generated headers. >>> >>> Riiighhht. So this is a very different code path altogether than >>> installing.... >>> >>> The installation step never happens. I thought the installation step >>> happened, but that it was installed somewhere in the build folder... >> >> Correct >> > > Just as a comment may be worth adding a common.mk for standard includes etc. > Started a similar patch but not found time to work on it. > > This makes adding directory specific includes much simpler, eg. > http://repo.or.cz/w/openocd/ntfreak.git/commitdiff/04734c8d0dfcca040c8376a83bf58d9e2826a73f
I agree. This is definitely the way to go. > > Cheers > Spen > -- µWeb: Embedded Web Framework - http://uweb.workware.net.au/ WorkWare Systems Pty Ltd W: www.workware.net.au P: 0434 921 300 E: [email protected] F: 07 3102 9221 _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
