Hi Mirda, --- MIroslav Dušek <[email protected]> schrieb am Sa, 27.11.2010:
> Hi Rolf, > Thank you for your patches, I apply them and flash probe 0 is OK now, > but I still have problems. >> flash info 0 > Command handler execution failed > in procedure 'flash' It looks like sending patches late at night was not a good idea... The attached patch should now work. There's also a patch to fix the broken config file for the Hitex LPC2900 board. Regards. Rolf
From e95fc2c340c5e51b5607c759ea5917db86aea61b Mon Sep 17 00:00:00 2001 From: Rolf Meeser <[email protected]> Date: Sat, 27 Nov 2010 22:34:16 +0100 Subject: [PATCH 1/2] Fix board config file Hitex LPC2929 --- tcl/board/hitex_lpc2929.cfg | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tcl/board/hitex_lpc2929.cfg b/tcl/board/hitex_lpc2929.cfg index d9ca110..13d3872 100644 --- a/tcl/board/hitex_lpc2929.cfg +++ b/tcl/board/hitex_lpc2929.cfg @@ -28,7 +28,7 @@ $_TARGETNAME configure -event reset-start { } # External 16-bit flash at chip select CS7 (SST39VF3201-70, 4 MiB) -set _FLASHNAME $_CHIPNAME.flash +set _FLASHNAME $_CHIPNAME.extflash flash bank $_FLASHNAME cfi 0x5C000000 0x400000 2 2 $_TARGETNAME jedec_probe -- 1.7.2.3
From 093e68452e10dfa23df749b97a32ff4c3f6efaa9 Mon Sep 17 00:00:00 2001 From: Rolf Meeser <[email protected]> Date: Sat, 27 Nov 2010 23:09:59 +0100 Subject: [PATCH 2/2] LPC2900: Avoid false positive reprobing if first probing fails --- src/flash/nor/lpc2900.c | 18 +++++++++++------- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/flash/nor/lpc2900.c b/src/flash/nor/lpc2900.c index e17823e..99d6d1d 100644 --- a/src/flash/nor/lpc2900.c +++ b/src/flash/nor/lpc2900.c @@ -132,6 +132,11 @@ struct lpc2900_flash_bank { /** + * This flag is set when the device has been successfully probed. + */ + bool is_probed; + + /** * Holds the value read from CHIPID register. * The driver will not load if the chipid doesn't match the expected * value of 0x209CE02B of the LPC2900 family. A probe will only be done @@ -255,7 +260,7 @@ static uint32_t lpc2900_is_ready( struct flash_bank *bank ) { struct lpc2900_flash_bank *lpc2900_info = bank->driver_priv; - if( lpc2900_info->chipid != EXPECTED_CHIPID ) + if( !lpc2900_info->is_probed ) { return ERROR_FLASH_BANK_NOT_PROBED; } @@ -512,8 +517,6 @@ static uint32_t lpc2900_calc_tr( uint32_t clock_var, uint32_t time_var ) /* ((time[µs]/1e6) * f[Hz]) + 511 * FPTR.TR = ------------------------------- * 512 - * - * The result is the */ uint32_t tr_val = (uint32_t)((((time_var / 1e6) * clock_var) + 511.0) / 512.0); @@ -1050,6 +1053,7 @@ FLASH_BANK_COMMAND_HANDLER(lpc2900_flash_bank_command) /* Chip ID will be obtained by probing the device later */ lpc2900_info->chipid = 0; + lpc2900_info->is_probed = false; return ERROR_OK; } @@ -1554,10 +1558,8 @@ static int lpc2900_probe(struct flash_bank *bank) return ERROR_TARGET_NOT_HALTED; } - /* We want to do this only once. Check if we already have a valid CHIPID, - * because then we will have already successfully probed the device. - */ - if (lpc2900_info->chipid == EXPECTED_CHIPID) + /* We want to do this only once. */ + if (lpc2900_info->is_probed) { return ERROR_OK; } @@ -1723,6 +1725,8 @@ static int lpc2900_probe(struct flash_bank *bank) offset += bank->sectors[i].size; } + lpc2900_info->is_probed = true; + /* Read sector security status */ if ( lpc2900_read_security_status(bank) != ERROR_OK ) { -- 1.7.2.3
_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
