Hi Mathias,

Yes, you're right and your patch works.
We can merge it.

Also, your patch make the code source smaller. ;-)

Regards,
Laurent
http://www.amontec.com

K. wrote:
Hello,

the mpsse buffer preparation and send functionality is done in:

ft2232_set_data_bits_low_byte
ft2232_set_data_bits_high_byte

You only need to deliver the port value and direction to this functions. Thats 
all.


Regards,

Mathias


Am 14.02.2011 10:36, schrieb Laurent Gauch:
Why removing a lot of code ?

As :

static int jtagkey_init(void)
{
-    uint8_t  buf[3];
-    uint32_t bytes_written;
-
    low_output    = 0x08;
    low_direction = 0x1b;

    /* initialize low byte for jtag */
-    buf[0] = 0x80;          /* command "set data bits low byte" */
-    buf[1] = low_output;    /* value (TMS = 1,TCK = 0, TDI = 0, nOE = 0) */
-    buf[2] = low_direction; /* dir (output = 1), TCK/TDI/TMS = out, TDO = in, 
nOE = out */
-    LOG_DEBUG("%2.2x %2.2x %2.2x", buf[0], buf[1], buf[2]);
-
-    if (ft2232_write(buf, sizeof(buf), &bytes_written) != ERROR_OK)
+    if (ft2232_set_data_bits_low_byte(low_output,low_direction) != ERROR_OK)
    {
        LOG_ERROR("couldn't initialize FT2232 with 'JTAGkey' layout");
        return ERROR_JTAG_INIT_FAILED;

Please explain?


Regards,
Laurent

http://www.amontec.com

_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development



_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to