On Mon, May 16, 2011 at 8:32 AM, Øyvind Harboe <oyvind.har...@zylin.com> wrote: > One thing that would help greatly for someone wanting to review > your patch is that you wrote it as a full, normal git patch with a comment.
Totally agree that there should be some systematic approach to development and patching of the OpenOCD - except code organization and its application implication it is also important to have control over changes, be able to see what has changed and how to revert it. For me it took sooo much time to understand how it works inside, the functions operating on global pointers/structures and void parameters instead clean program flow, that I really understand you Oyvind that you push users/developers to make their work clean. Laurent please understand that your patch is one of hundreds to process and maintain by Oyvind and this is not trivial task to get along with all of these - I guess this is why the question came from... OpenOCD need internal cleaning and reogranization soon anyway as its capabilities now extend simple JTAG and flash access and people want even more of it, so another dirty patches dont help in here :-) Best regads, peace and clean code! ;-) :-) Tomek -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
