>> Btw.: There is still an endianness issue with mips target. Drasko adds >> endianness swapping (that I removed two years ago) > Why did you remove it ?
I removed swapping in mips_m4k, because for commands like mdw the swapping was already done in target.c. If a target was selected as big endian, swapping was done twice. So setting endianness had no effect. I did not realized that dump_image works different. Since you revert this change, same issue again :) BR, Stefan -----Ursprüngliche Nachricht----- Von: Drasko DRASKOVIC [mailto:[email protected]] Gesendet: Donnerstag, 26. Mai 2011 12:12 An: Mahr, Stefan Cc: [email protected] Betreff: Re: [PATCH] mips target On Wed, May 25, 2011 at 4:28 PM, Mahr, Stefan <[email protected]> wrote: > Hi, > > attached patch fixes the endianess so mips/ejtag can be used on a big endian > host. > > > Btw.: There is still an endianness issue with mips target. Drasko adds > endianness swapping (that I removed two years ago) Why did you remove it ? > to mips_m4k.c (commit b1256894598296b54a1827e7ac797ad1c60a0b18). But some > swapping is already done in target.c, e.g. for target_get_buffer_u32. While > "dump_image" works fine, "mdw" does not. > To my mind whole endianness > swapping should be done in target.c, not in mips_m4k. I put it where it was before, but I agree that we should do the swap in target.c. > What do you think? I'll have to test this, and I'll not have MIPS board before beginning of next week. Otherwise I can not tell if it's correct. From my memory, I'd say that mdw worked correctly for me... Best regards, Drasko _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
