i messed something up during the last changes, this patch fixes it.
i'll be doing a lot of testing during the next days.

sorry for the trouble...

On Wed, Jun 29, 2011 at 1:13 PM, Rodrigo Rosa <[email protected]> wrote:
> On Wed, Jun 29, 2011 at 12:20 PM, Øyvind Harboe <[email protected]> 
> wrote:
>>>> Seperate patch? Does this have anything to do with fixing warnings?
>>>>
>>>> -      counter = FLUSH_COUNT_FLASH;
>>>> +      counter = FLUSH_COUNT_READ_WRITE;
>>>>
>>>
>>> nothing to do with warnings, but it doesn't really affect anything,
>>> since both constants are defined to the same value (i'm was
>>> experimenting with them some time ago)
>>
>> Fixing warnings should be in a separate patch really.l
>>
>
> it split the first of the two commits:
> git rebase -i origin/master
> --> chose "edit" on the commit i wanted to modify.
> git reset HEAD^
> --> now the changes from the selected commit are not staged
> --> changed stuff
> git add
> git commit
> --> first part done
> --> change more stuff
> git add
> git commit
> --> done splitting commit
> git rebase --continue
> git format-patch origin/master
>
> pretty cool :)
>
>
>
>>>>> do you have any clue about what i'm doing wrong?
>>>>
>>>> What warnings you get depend on what compiler you're using.
>>>>
>>>> try
>>>>
>>>> CFLAGS="-O3 -g" configure xxxxxx
>>>>
>>>
>>> i do not get the warnings.
>>> i've been reading a bit, and those warnings should only appear if
>>> -Wcast-align is set.
>>> i tried
>>> ./configure --enable-mantainer-mode  --enable-ft2232-libftdi
>>> CFLAGS="-O3 -g -Wcast-align"
>>> but still no warnings...
>>> what flags are you using?
>>
>> I don't know precisely why some target compilers have more than
>> others. nios2-elf-gcc gives genuine warnings that I would have liked
>> to see from x86 as well. Gcc versions? Something in the target definition
>> defaults?
>>
>> --
>> Øyvind Harboe - Can Zylin Consulting help on your project?
>> US toll free 1-866-980-3434 / International +47 51 87 40 27
>> http://www.zylin.com/
>>
>
>
>
> --
> Rodrigo.
>



-- 
Rodrigo.

Attachment: 0004-fix-write-error.patch
Description: Binary data

_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to