Hi,
On Sun, Oct 2, 2011 at 7:34 PM, Karl Kurbjun <[email protected]> wrote:
> This additional output was helpful when debugging a FTDI device with a
> broken
> EEPROM. I was expecting to connect to a cable with a particular
> description,
> but the device was not found. This error message would helps quickly
> identify
> the connection failure.
>
A few comments:
Avoid unrelated whitespace changes:
- layout->name, vid, pid);
+ layout->name, vid, pid);
Don't include unrelated style fixes. Besides, single statement bodies
shouldn't have braces according to the kernel coding style, which we have
more or less agreed to apply for OpenOCD.
if (more)
+ {
LOG_WARNING("unable to open ftdi device (trying more): %s",
ftdic.error_str);
+ }
else
+ {
LOG_ERROR("unable to open ftdi device: %s", ftdic.error_str);
+ }
Maybe a little *too* good job of limiting the scope:
+ /* Limit the scope of these variables */
+ int i = 0;
+ i++;
On a more general note, I'm not sure ft2232_init_libftdi is the correct
place to dump all found devices, because if I'm not mistaken, it may get
called several times if multiple vid/pid combinations are registered.
Regards,
Andreas
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development
