On 2011-10-21 19:09, Øyvind Harboe (Code Review) wrote:
> Please look up the discussion of why this code was modified to use
> uplevel and amend the commit with an explanation of why we should use
> the proposed behaviour instead.
I cannot comment on Gerrit...
The discussion -
https://lists.berlios.de/pipermail/openocd-development/2011-August/020462.html
- not easy to find (links to list are links to NEW and EMPTY sourceforge
forum) so I had to google that up. There is absolutely no discussion or
reasoning there, this change was introduced "just because" and based on
"why not?".
Or maybe there's another discussion I cannot find.
The commit message I've made has an explanation of why the change was
reverted. Or maybe a change in behavior for Windows users is not a
reason to revert a patch that introduced it by mistake? To reiterate -
now OpenOCD does NOT work as manual says. This is a change in behavior
that did not ever change and never was intended to change.
4\/3!!
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development