This is an automated email from Gerrit.
Antonio Borneo (borneo.anto...@gmail.com) just uploaded a new patch set to
Gerrit, which you can find at http://openocd.zylin.com/84
-- gerrit
commit 7c966dc57e22dddcf6df16f6761d90958e4dc6f2
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date: Sun Oct 23 11:21:44 2011 +0800
FLASH/CFI: fix clang warnings
Total of 5 warnings:
3x "Dead store": removed dead assignment to variable;
1x "Dereference of null pointer": this is not an error, but a
limited visibility of clang, since pointer erase_region_info
is initialized inside cfi_fixup_non_cfi();
1x "Branch condition evaluates to a garbage value":
this is a real coding bug that could issue SIGSEGV, since
"goto cleanup" can be executed before initialization
of "source".
Change-Id: Id3c323c82bb15cbd3bb8fc04b23541f11145f109
Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
diff --git a/src/flash/nor/cfi.c b/src/flash/nor/cfi.c
index 5d35801..f75efac 100644
--- a/src/flash/nor/cfi.c
+++ b/src/flash/nor/cfi.c
@@ -768,7 +768,7 @@ static int cfi_spansion_info(struct flash_bank *bank, char
*buf, int buf_size)
buf += printed;
buf_size -= printed;
- printed = snprintf(buf, buf_size, "VppMin: %u.%x, VppMax: %u.%x\n",
+ snprintf(buf, buf_size, "VppMin: %u.%x, VppMax: %u.%x\n",
(pri_ext->VppMin & 0xf0) >> 4, pri_ext->VppMin & 0x0f,
(pri_ext->VppMax & 0xf0) >> 4, pri_ext->VppMax & 0x0f);
@@ -802,7 +802,7 @@ static int cfi_intel_info(struct flash_bank *bank, char
*buf, int buf_size)
buf += printed;
buf_size -= printed;
- printed = snprintf(buf, buf_size, "protection_fields: %i,
prot_reg_addr: 0x%x, "
+ snprintf(buf, buf_size, "protection_fields: %i, prot_reg_addr: 0x%x, "
"factory pre-programmed: %i, user programmable: %i\n",
pri_ext->num_protection_fields, pri_ext->prot_reg_addr,
1 << pri_ext->fact_prot_reg_size, 1 <<
pri_ext->user_prot_reg_size);
@@ -1222,7 +1222,7 @@ static int cfi_intel_write_block(struct flash_bank *bank,
uint8_t *buffer,
struct target *target = bank->target;
struct reg_param reg_params[7];
struct arm_algorithm armv4_5_info;
- struct working_area *source;
+ struct working_area *source = NULL;
uint32_t buffer_size = 32768;
uint32_t write_command_val, busy_pattern_val, error_pattern_val;
@@ -2704,6 +2704,7 @@ static int cfi_probe(struct flash_bank *bank)
}
cfi_info->probed = 0;
+ cfi_info->num_erase_regions = 0;
if (bank->sectors)
{
free(bank->sectors);
@@ -3151,7 +3152,7 @@ static int get_cfi_info(struct flash_bank *bank, char
*buf, int buf_size)
if (cfi_info->qry[0] == 0xff)
{
- printed = snprintf(buf, buf_size, "\ncfi flash bank not probed
yet\n");
+ snprintf(buf, buf_size, "\ncfi flash bank not probed yet\n");
return ERROR_OK;
}
--
_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
