Request 258 was acted upon.
_________________________________________________________________________

         URL: https://rt.openpkg.org/id/258
      Ticket: [OpenPKG #258]
     Subject: [pine] patch for SSL
  Requestors: [EMAIL PROTECTED]
       Queue: openpkg
       Owner: Nobody
      Status: new
 Transaction: Ticket created by [EMAIL PROTECTED]
        Time: Tue Sep 16 04:38:00 2003
_________________________________________________________________________

This transaction appears to have no content
The recently-created pine package seems to make a small mistake when
invoking the "build" script provided by the upstream source:

The script is Bourne shell, not a Makefile, so positional parameters and
environment variables are not interchangeable.

The %build section passes its configuration to the build script as
environment variables, which are ignored. In most cases, this doesn't
matter since the build autodetects the basic of its host's environment.

When specifying OpenSSL parameters, however, the parameters are
necessary.

The patch attached converts the use of environment variables to
command-line arguments. In addition, it explicitly disables LDAP support
which will be autodetected if not otherwise specified.

--Matt

-- 
Matt Hoosier
UNIX Administrator / Accounts Manager
Department of Computing and Information Sciences
Kansas State University
diff -urN ../pine-orig/pine.spec ./pine.spec
--- ../pine-orig/pine.spec	2003-09-15 21:18:12.676944000 -0500
+++ ./pine.spec	2003-09-15 21:22:56.592193000 -0500
@@ -98,16 +98,18 @@
     sh ./build clean
 
     #   build Pine
-    CC="%{l_cc}" \
-    EXTRACFLAGS="%{l_cflags -O}" \
-    EXTRALDFLAGS="%{l_ldflags}" \
+    sh ./build \
+        CC="%{l_cc}" \
+        EXTRACFLAGS="%{l_cflags -O}" \
+        EXTRALDFLAGS="%{l_ldflags}" \
+        NOLDAP \
 %if "%{with_ssl}" == "yes"
-    SSLDIR="%{l_prefix}" \
-    SSLTYPE="unix" \
-    sh ./build $OS
+        SSLDIR="%{l_prefix}" \
+        SSLTYPE="unix" \
 %else
-    sh ./build NOSSL $OS
+        NOSSL \
 %endif
+        $OS
 
 %install
     rm -rf $RPM_BUILD_ROOT

Attachment: signature.asc
Description: PGP signature

Reply via email to