OpenPKG CVS Repository
  http://cvs.openpkg.org/
  ____________________________________________________________________________

  Server: cvs.openpkg.org                  Name:   Ralf S. Engelschall
  Root:   /v/openpkg/cvs                   Email:  [EMAIL PROTECTED]
  Module: openpkg-src                      Date:   13-Aug-2005 14:20:32
  Branch: HEAD                             Handle: 2005081313203200

  Modified files:
    openpkg-src/thunderbird thunderbird.patch thunderbird.spec

  Log:
    One more: Fix generation of random multicast MAC address.
    
    In case no real/physical IEEE 802 address is available, both the expired
    "draft-leach-uuids-guids-01" (section "4. Node IDs when no IEEE 802
    network card is available") and RFC 2518 (section "6.4.1 Node Field
    Generation Without the IEEE 802 Address") recommend (quoted from RFC
    2518):
    
      "The ideal solution is to obtain a 47 bit cryptographic quality random
      number, and use it as the low 47 bits of the node ID, with the _most_
      significant bit of the first octet of the node ID set to 1. This bit
      is the unicast/multicast bit, which will never be set in IEEE 802
      addresses obtained from network cards; hence, there can never be a
      conflict between UUIDs generated by machines with and without network
      cards."
    
    Unfortunately, this incorrectly explains how to implement this and
    the Mozilla UUID generator code inherited this generation bug from
    the broken reference code in the standards draft. They should instead
    specify the "_least_ significant bit of the first octet of the node ID"
    as the multicast bit in a memory and hexadecimal string representation
    of a 48-bit IEEE 802 MAC address.
    
    This standards bug arised from a false interpretation, as the multicast
    bit is actually the _most_ significant bit in IEEE 802.3 (Ethernet)
    _transmission order_ of an IEEE 802 MAC address. The standards authors
    forgot that the bitwise order of an _octet_ from a MAC address _memory_
    and hexadecimal string representation is still always from left (MSB,
    bit 7) to right (LSB, bit 0).

  Summary:
    Revision    Changes     Path
    1.2         +12 -0      openpkg-src/thunderbird/thunderbird.patch
    1.5         +1  -1      openpkg-src/thunderbird/thunderbird.spec
  ____________________________________________________________________________

  patch -p0 <<'@@ .'
  Index: openpkg-src/thunderbird/thunderbird.patch
  ============================================================================
  $ cvs diff -u -r1.1 -r1.2 thunderbird.patch
  --- openpkg-src/thunderbird/thunderbird.patch 24 Mar 2005 18:03:30 -0000      
1.1
  +++ openpkg-src/thunderbird/thunderbird.patch 13 Aug 2005 12:20:32 -0000      
1.2
  @@ -117,3 +117,15 @@
    #include <cairo.h>
    
    /**
  +Index: calendar/libxpical/token.c
  +--- calendar/libxpical/token.c.orig  2003-10-24 22:40:32 +0200
  ++++ calendar/libxpical/token.c       2005-08-13 13:13:58 +0200
  +@@ -266,7 +266,7 @@
  +     unsigned char seed[16];
  + 
  +     get_random_info(seed);
  +-    seed[0] |= 0x80;
  ++    seed[0] |= 0x01;
  +     memcpy(node, seed, sizeof(*node));
  + }
  + 
  @@ .
  patch -p0 <<'@@ .'
  Index: openpkg-src/thunderbird/thunderbird.spec
  ============================================================================
  $ cvs diff -u -r1.4 -r1.5 thunderbird.spec
  --- openpkg-src/thunderbird/thunderbird.spec  22 Jul 2005 09:34:22 -0000      
1.4
  +++ openpkg-src/thunderbird/thunderbird.spec  13 Aug 2005 12:20:32 -0000      
1.5
  @@ -33,7 +33,7 @@
   Group:        Web
   License:      MPL
   Version:      1.0.6
  -Release:      20050722
  +Release:      20050813
   
   #   package options
   %option       with_optimize   yes
  @@ .
______________________________________________________________________
The OpenPKG Project                                    www.openpkg.org
CVS Repository Commit List                     [email protected]

Reply via email to