On Wed, Apr 14, 2004, OpenPKG Project Robot wrote:

> The following OpenPKG Contribution Area operation occurred.
> uploaded RPM file "dracd-1.12-2.0.0noc.src.rpm" accepted -- moved to contrib area.
> No action is required on your part.
>
> Information about dracd-1.12-2.0.0noc.src.rpm follows:
> | Name:     dracd                     Source RPM:   (none)
> | Version:  1.12                      Signature:    
> md5:af4f95c22a01c5f4b787ff31b857dd77
> | Release:  2.0.0noc                  Build Host:   openpkg
> | Group:    Mail                      Build System: sparc64-solaris9
> | Class:    (none)                    Build Time:   Wed Apr 14 11:03:16 2004
> | Distrib:  Fraunhofer NOC OpenPKG    Install Time: (not installed)
> | License:  BSD                       Install Size: 27016 bytes
> | Packager: Fraunhofer Network Operations Center Relocations:  (not relocateable)
> | Vendor:   University of Manitoba
> | Summary:  Dynamic Relay Authorization Control
> | URL:      http://mail.cc.umanitoba.ca/drac/
> | Description:
> |     DRAC is a daemon that dynamically updates a relay authorization map for
> |     Sendmail, Postfix and other MTA's that supports it. It provides a way to allow
> |     legitimate users to relay mail through an SMTP server, while still preventing
> |     others from using it as a spam relay. User's IP addresses are added to the map
> |     immediately after they have authenticated to the POP or IMAP server. By
> |     default, map entries expire after 30 minutes, but can be renewed by additional
> |     authentication. Periodically checking mail on a POP server is sufficient to do
> |     this. The POP and SMTP servers can be on different hosts.
> | Provides:
> |     dracd::with_fsl = yes
> | Files:
> | -rw-r--r-- 1 root          other            20705 Apr 13 10:03 drac.tar.Z
> | -rw-r--r-- 1 root          other             5273 Apr 14 11:02 dracd.spec
> | -rw-r--r-- 1 root          other              257 Apr 13 10:03 fsl.dracd
> | -rw-r--r-- 1 root          other              781 Apr 13 10:03 rc.dracd

Thanks for your contribution. After massaging the package a little
bit more, I've comitted it now to CVS for OpenPKG-CURRENT under the
name "drac" (no "d" because it contains both the server program and
the client library). See http://cvs.openpkg.org/chngview?cn=15886 for
details.

Because a "diff" between yours and the comitted stuff is rather large
(because of renamings, etc), here is my feedback for you in the hope it
helps you to further improve your packaging skills:

- a dependency to "gcc" is required because of the "rpcgen -Y" stuff

- I've decided to manually install the package files because they are
  just 4 files and this way I was able to reduce the patching complexity
  in the Makefile.

- The package used man/man1m/ which is not acceptable. It has to be man/man1
  or (because its a daemon) even better: man/man8. Same for the daemon
  itself: it was named bin/rpc.dracd, but I preferred sbin/dracd
  instead for consistency.

- A %config entry for etc/dracd.db is required in the %files section.

- rcService checks were missing in rc.drac(d) and the %config section
  in rc.drac(d) especially had no drac(s)_enable. Also a %status section
  was missing.

- a %track section was missing in drac(d).spec.

- the rc.drac(d) usage of "rpmtool signal" is too weak in practice,
  so I replaced this with real pidfile support.

Nevertheless, your packaging skills are already great.
Keep on your good work!

Yours,
                                       Ralf S. Engelschall
                                       [EMAIL PROTECTED]
                                       www.engelschall.com

______________________________________________________________________
The OpenPKG Project                                    www.openpkg.org
Developer Communication List                   [EMAIL PROTECTED]

Reply via email to