On Fri, Jun 21, 2002, Michael Schloh wrote:
> [...]
> Ripped out gcc-specific build defs and removed thread switch. Please
> review, as I might have ripped out too much.
> [...]
> - CC="%{l_cc}" CFLAGS="%{l_cflags -O}" ./configure
> - %{l_make} %{l_mflags} OPT="%{l_cflags -O}" DEBUG=0
> + CC="%{l_cc}" ./configure
> + %{l_make} %{l_mflags} DEBUG=0
Err... why are you removing the whole CFLAGS stuff? This has nothing to
do with gcc-specific build defs, Michael. l_cflags automatically adjusts
itself according to the value of l_cc. So that's fine to have CFLAGS there.
> [...]
> - CFLAGS="%{l_cflags -O}"
> - case "%{l_target}" in
> - *-freebsd* ) CFLAGS="$CFLAGS -pthread" ;;
> - esac
> [...]
Same here, why have you removed this for FreeBSD? On FreeBSD the
compiler (by coincidence) is always GCC, so keeping -pthread there is
ok. I don't know why it was there, but it had a reason and for just
FreeBSD it doesn't harm. I complained in pgp2 because you did it for
Solaris where not every compiler OpenPKG finds is gcc.
Ralf S. Engelschall
[EMAIL PROTECTED]
www.engelschall.com
______________________________________________________________________
The OpenPKG Project www.openpkg.org
Developer Communication List [EMAIL PROTECTED]
