On Fri, Jun 21, 2002 at 10:01:08PM +0200, Ralf S. Engelschall wrote:
> Log:
> Fix the following issues:
>
> 1. As I already said, using -pthread[s] is useless unless the
> application uses any Pthread functions. PGP 2.x doesn't:
>
Agreed.
> 2. Even if it would be correct to use the above Pthread fiddling, you
> still do not depend on "gcc" and hence %{l_cc} still could be the
> Workshop compiler on a Solaris box.
>
When using the makefile targets, the Workshop compiler is supported. Now we
are hardcoding gcc in, limiting portability.
> 3. If you look inside src/makefile of PGP 2.x you will recognize that
> all this is fully broken, because only a few platforms respect $(CC).
> Most (like Solaris) force it to something like CC=gcc, etc.
>
That's why your hardcoding of gcc is probably the easiest way. Otherwise we
would have to determine the compiler used at build time and then select the
correct target determined on the choice.
> 4. In your latest version above you now have the init of CFLAGS twice.
>
Thanks for the correction.
> 5. Your OS=sun4gcc should be OS=sun4sunos5gcc, because sun4gcc is
> for the good old braindead SunOS 4 (although this still might work on
> SunOS 5).
>
No, I intentionally did this for wider range of portability. The only
difference between these two targets is that the sunos5 one breaks on less
than new environments. Basically, it adds an assembler flag for optimization
and doesn't build the memmove object which is probably needed for an older sun
OS.
> 6. In general the whole direct $OS determination is predestined to fail
> because it restricts you to a _very_ limited set of platforms.
> Something like a small decision hierarchy approach is needed here.
>
This small decision hierarchy breaks on my Solaris box. It is possible that it
fails in other environments, too. What is most important however, is that it
succeeds on our three supported platforms. So its mostly okay.
> 7. PGP complains under run-time:
>
> | openpkg-dev$ /cw/bin/pgp -kg
> | Pretty Good Privacy(tm) 2.6.3ia - Public-key encryption for the masses.
> | (c) 1990-96 Philip Zimmermann, Phil's Pretty Good Software. 1996-03-04
> | International version - not for use in the USA. Does not use RSAREF.
> | Current time: 2002/06/21 19:49 GMT
> |
> | Error: PGP User's Guide not found.
> | PGP looked for it in the following directories:
>
> The pgpdoc[12].txt files are missing.
>
Yes, you're right.
> 8. The binary and man-page you install conflicts with the files in our "pgp"
> package. A "pgp2" package should install <prefix>/bin/pgp2, of course.
>
I had not in mind a non-conflicting package, but if our policy states that
(like I think it does) then I appologize. This archive package is a little
different than the situation with gcc2, though. Almost nobody will want both
PGP versions, whereas many people find useful several versions of gcc at once.
> 9. The package "Distribution" is "OpenPKG [REL]" instead of "OpenPKG [EXP]".
>
I copied REL from package pgp, which went out in OpenPKG version 1.0.
Thanks for the spec file improvements. The package is mostly finished now
thank god.
Regards,
Michael
--
[EMAIL PROTECTED]
Development Team, Application Services
Cable & Wireless Deutschland GmbH
______________________________________________________________________
The OpenPKG Project www.openpkg.org
Developer Communication List [EMAIL PROTECTED]
