On Fri, Nov 08, 2002, Peter Smej wrote:
> [...]
> Modified files:
> openpkg-re/vcheck vc.binutils
> openpkg-src/binutils binutils.spec
> openpkg-web news.txt
>
> Log:
> upgrading package: binutils 2.13 -> 2.13.1
> [...]
> Source0:
>ftp://sources.redhat.com/pub/binutils/releases/binutils-%{version}.tar.bz2
> -Patch0: binutils.patch
>
> # build information
> Prefix: %{l_prefix}
> @@ -65,7 +64,6 @@
>
> %prep
> %setup -q
> - %patch -p0
> [...]
Errr... sorry, perhaps I was not clear enough: Yes, I said we should
remove patches at all if they are obsolete. But I really meant "...
if they are obsolete" and have not said anything like "... always".
The patch for GNU binutils we had is important and this upgrade broke
binutils at least for FreeBSD. I've resurrected the patch, but please be
more careful in upgrading.
Do not remove any patching just because a new upstream/vendor version
is available. This sometimes means a patch is obsolete (if the vendor
integrated our patch or at least fixed it theirself), but most of the
time this is not true. Especially, even if _parts_ of a patch are
obsoleted, this doesn't mean the remaining patches are not needed and
the patch can be removed as a whole.
Additionally: removing the Patch0: and %patch lines just removes the
_usage_ of a patch. If such a step is done we also have to also remove
the patch file (binutils.patch) from the source tree, of course ("rm
binutils.patch; cvs rm binutils.patch").
Ralf S. Engelschall
[EMAIL PROTECTED]
www.engelschall.com
______________________________________________________________________
The OpenPKG Project www.openpkg.org
Developer Communication List [EMAIL PROTECTED]
