On Fri, Nov 22, 2002, Peter Smej wrote:
> [...]
> upgrading package: tsmc 4.2.2.1 -> 5.1.5.2
> [...]
> - ResourceUtilization 4
> - ChangingRetries 3
> - MaxCmdRetries 3
> - RetryPeriod 15
> - MemoryEff yes
> + ResourceUtilization @resutil@
What is the reason why the other parameters were removed, too?
> -prog="`echo $0 | sed -e 's;.*/\([^/]*\)$;\1;'`"
> +
> +prog="dsmc"
> +
Errr... this breaks the stuff and only works any longer if the command
is "dsmc" and is in $PATH. Any other usage is now broken. Please be more
carefully in not breaking existing things.
> -LD_LIBRARY_PATH=""
> -for dir in /lib /usr/lib /usr/ccs/lib; do
> - if [ -d $dir ]; then
> - if [ ".$LD_LIBRARY_PATH" = . ]; then
> - LD_LIBRARY_PATH="$dir"
> - else
> - LD_LIBRARY_PATH="$dir:${LD_LIBRARY_PATH}"
> - fi
> - fi
> -done
> -if [ -d "$prefix/libexec/tsmc/lib" ]; then
> - LD_LIBRARY_PATH="$prefix/libexec/tsmc/lib:${LD_LIBRARY_PATH}"
> -fi
> -export LD_LIBRARY_PATH
What is the reason why the LD_LIBRARY_PATH fiddling was removed, too?
> [...]
> -BuildPreReq: OpenPKG, openpkg >= 20021120
> -PreReq: OpenPKG, openpkg >= 20021120
> +BuildPreReq: OpenPKG, openpkg >= 20021009, tar, gzip
> +PreReq: OpenPKG, openpkg >= 20021009
> AutoReq: no
> AutoReqProv: no
> [...]
Errr.. sorry, but I've to complain again here: just copying over your
version over the latest CVS version is _NOT_ the way to do. This way you
again accidentely removed changes which were made between the date you
started hacking and the date you comitted your changes. Please in the
future, work directly with CVS checked out versions. This way you do not
loose those changes.
> [...]
> esac
>
> +
> %install
> rm -rf $RPM_BUILD_ROOT
> [...]
Please do not commit those blank lines or other whitespaces.
> [...]
> # install default configuration
> %{l_shtool} install -c -m 755 \
> + -e 's;@resutil@;'$l_resutil';g' \
> [...]
Hint: no need to do it such complicated: just use "s;@resutil@;$l_resutil;g" here.
> [...]
> - rm -rf $RPM_BUILD_ROOT
> +# rm -rf $RPM_BUILD_ROOT
Again, please review your commits more carefully. This is not intended
to be comitted this way.
Ralf S. Engelschall
[EMAIL PROTECTED]
www.engelschall.com
______________________________________________________________________
The OpenPKG Project www.openpkg.org
Developer Communication List [EMAIL PROTECTED]
