On Fri, Jan 31, 2003, Peter Smej wrote:

>   patch -p0 <<'@@ .'
>   Index: openpkg-src/xmms/xmms.patch
>   ============================================================================
>   $ cvs diff -u -r0 -r1.1 xmms.patch
>   --- /dev/null       2003-01-31 10:35:16.000000000 +0100
>   +++ xmms.patch      2003-01-31 10:35:16.000000000 +0100
>   @@ -0,0 +1,15 @@
>   +--- Input/mpg123/fileinfo.c.orig   Thu Jan 30 09:30:08 2003
>   ++++ Input/mpg123/fileinfo.c        Thu Jan 30 09:30:23 2003
>   +@@ -130,9 +130,9 @@
>   +   va_list args;
>   +   gchar tempstr[MAX_STR_LEN];
>   +
>   +-  va_start(args, str);
>   +-  g_vsnprintf(tempstr, MAX_STR_LEN, str, args);
>   +-  va_end(args);
>   ++  //va_start(args, str);
>   ++  //g_vsnprintf(tempstr, MAX_STR_LEN, str, args);
>   ++  //va_end(args);
>   +
>   +   gtk_label_set_text(GTK_LABEL(label), tempstr);
>   + }

What problem is this patch intended to fix, Peter?
At least keep in mind that you cause a segfault here, because
tempstr is uninitialized and still feeded into gtk_label_set_text()...

                                       Ralf S. Engelschall
                                       [EMAIL PROTECTED]
                                       www.engelschall.com

______________________________________________________________________
The OpenPKG Project                                    www.openpkg.org
Developer Communication List                   [EMAIL PROTECTED]

Reply via email to