OpenPKG CVS Repository http://cvs.openpkg.org/ ____________________________________________________________________________
Server: cvs.openpkg.org Name: Ralf S. Engelschall Root: /e/openpkg/cvs Email: [EMAIL PROTECTED] Module: openpkg-re Date: 08-Jul-2003 20:15:05 Branch: HEAD Handle: 2003070819150300 Modified files: openpkg-re speclint.pl Log: finally activate l_ldflags and l_cppflags checks; fix deactivated line length check Summary: Revision Changes Path 1.30 +18 -18 openpkg-re/speclint.pl ____________________________________________________________________________ patch -p0 <<'@@ .' Index: openpkg-re/speclint.pl ============================================================================ $ cvs diff -u -r1.29 -r1.30 speclint.pl --- openpkg-re/speclint.pl 8 Jul 2003 17:04:31 -0000 1.29 +++ openpkg-re/speclint.pl 8 Jul 2003 18:15:03 -0000 1.30 @@ -737,24 +737,24 @@ } # check for obsolete cpp build flags - #$done = $outer_done; $this = ''; $todo = $outer_this; - #while ($todo =~ m/-I\%\{l_prefix\}\/include(\/([^ \t"';]+?))?[ \t"';]/s) { - # $done .= $`; $this = $&; $todo = $'; - # my ($subdir) = $2; - # &lint_warning($file, $done, $this, "section $section: hard-coded C pre-processor path option " . - # "(use \"%{l_cppflags".($subdir ? " $subdir" : "")."}\" instead)"); - # $done .= $this; - #} + $done = $outer_done; $this = ''; $todo = $outer_this; + while ($todo =~ m/-I\%\{l_prefix\}\/include(\/([^ \t"';]+?))?[ \t"';]/s) { + $done .= $`; $this = $&; $todo = $'; + my ($subdir) = $2; + &lint_warning($file, $done, $this, "section $section: hard-coded C pre-processor path option " . + "(use \"%{l_cppflags".($subdir ? " $subdir" : "")."}\" instead)"); + $done .= $this; + } # check for obsolete ld build flags - #$done = $outer_done; $this = ''; $todo = $outer_this; - #while ($todo =~ m/-L\%\{l_prefix\}\/lib(\/([^ \t"';]+?))?[ \t"';]/s) { - # $done .= $`; $this = $&; $todo = $'; - # my ($subdir) = $2; - # &lint_warning($file, $done, $this, "section $section: hard-coded linker path option " . - # "(use \"%{l_ldflags".($subdir ? " $subdir" : "")."}\" instead)"); - # $done .= $this; - #} + $done = $outer_done; $this = ''; $todo = $outer_this; + while ($todo =~ m/-L\%\{l_prefix\}\/lib(\/([^ \t"';]+?))?[ \t"';]/s) { + $done .= $`; $this = $&; $todo = $'; + my ($subdir) = $2; + &lint_warning($file, $done, $this, "section $section: hard-coded linker path option " . + "(use \"%{l_ldflags".($subdir ? " $subdir" : "")."}\" instead)"); + $done .= $this; + } # check for "raw" tool usage if ($section ne '%description' and $file !~ m|openpkg\.spec$|) { @@ -807,10 +807,10 @@ # FIXME: activate later # check for over-long lines #$done = ''; $this = ''; $todo = $spec; - #while ($todo =~ m/([^\n]{78,})\n/s) { + #while ($todo =~ m/([^\n]{80,})\n/s) { # $done .= $`; $this = $&; $todo = $'; # &lint_warning($file, $done, $this, "over-long line with ".sprintf("%d", length($1))." characters " . - # "(expected maximum of 78 characters)"); + # "(expected maximum of 79 characters)"); # $done .= $this; #} } @@ . ______________________________________________________________________ The OpenPKG Project www.openpkg.org CVS Repository Commit List [EMAIL PROTECTED]