OpenPKG CVS Repository
  http://cvs.openpkg.org/
  ____________________________________________________________________________

  Server: cvs.openpkg.org                  Name:   Ralf S. Engelschall
  Root:   /e/openpkg/cvs                   Email:  [EMAIL PROTECTED]
  Module: openpkg-re                       Date:   30-Aug-2003 09:53:29
  Branch: HEAD                             Handle: 2003083008532800

  Modified files:
    openpkg-re              rclint.pl

  Log:
    I don't think %config, %common and %info should have rcService
    short-circuiting checks for enabling

  Summary:
    Revision    Changes     Path
    1.19        +10 -8      openpkg-re/rclint.pl
  ____________________________________________________________________________

  patch -p0 <<'@@ .'
  Index: openpkg-re/rclint.pl
  ============================================================================
  $ cvs diff -u -r1.18 -r1.19 rclint.pl
  --- openpkg-re/rclint.pl      28 Aug 2003 13:54:37 -0000      1.18
  +++ openpkg-re/rclint.pl      30 Aug 2003 07:53:28 -0000      1.19
  @@ -438,15 +438,17 @@
       }
   
       #   check rcService short circuit
  -    $done = $outer_done; $this = ''; $todo = $outer_this;
  -    if ( $todo !~ m/^[^\n]+\n    rcService \w+ enable yes \|\| exit 0\n/s ) {
  -        &lint_warning($file, $done, $this, "section $section: \"rcService ... 
enable yes\" short circuit missing");
  -    }
  -    else {
  -        #   check rcService package reference
  +    if ($section !~ m/^%(config|common|info)$/) {
           $done = $outer_done; $this = ''; $todo = $outer_this;
  -        if ( $todo !~ m/\brcService\s+$pkgu\s+/s ) {
  -            &lint_warning($file, $done, $this, "section $section: rcService 
referencing wrong package");
  +        if ( $todo !~ m/^[^\n]+\n    rcService \w+ enable yes \|\| exit 0\n/s ) {
  +            &lint_warning($file, $done, $this, "section $section: \"rcService ... 
enable yes\" short circuit missing");
  +        }
  +        else {
  +            #   check rcService package reference
  +            $done = $outer_done; $this = ''; $todo = $outer_this;
  +            if ( $todo !~ m/\brcService\s+$pkgu\s+/s ) {
  +                &lint_warning($file, $done, $this, "section $section: rcService 
referencing wrong package");
  +            }
           }
       }
   
  @@ .
______________________________________________________________________
The OpenPKG Project                                    www.openpkg.org
CVS Repository Commit List                     [EMAIL PROTECTED]

Reply via email to