Thanks for your contribution, Steffen. In my role as the principal
architect, here is my usual amount of boring feedback from me ;-)
On Wed, Jun 08, 2005, Steffen Weinreich wrote:
> new package: sipsak 0.8.12 (SIP swiss army knife)
> [...]
> +Summary: SIP swiss army knife
> [...]
Just for consistency reasons: on the "Summary" line we usually use
All-Caps words as in "SIP Swiss Army Knife".
> +License: GPL
> [...]
> +BuildPreReq: OpenPKG, openpkg >= 20040130
> +PreReq: OpenPKG, openpkg >= 20040130
Watching the "configure" output and "cc" linking I see that it requires
at least OpenSSL's libcrypto. So, we have to add a dependency to
"openssl" here.
> +%description
> + sipsak is the most badly packaged program in the OpenPKG world.
> [...]
Hopefully not! ;-)
I'm wondering why "opd lint" has not catched this...
Please try to provide a more "positive" description next time.
> [...]
> +%build
> + CC="%{l_cc}" \
> + CXX="%{l_cxx}" \
> + CFLAGS="%{l_cflags -O}" \
> + CXXFLAGS="%{l_cxxflags -O}" \
> + CPPFLAGS="%{l_cppflags}" \
> + LDFLAGS="%{l_ldflags}" \
Sipsak is a C only program (no C++ parts AFAIK), so no need to pass C++
build flags here.
Finally, this program failed to build under Solaris (check
rm1.openpkg.net), because it uses MAXHOSTNAMELEN but did not include
<netdb.h> where this macro is usually defined according to POSIX.
I suggest you the appended patch to fix all those issues. Please review
it in detail and ask me in case of any unclear parts. If you are also
happy with it, then feel free to apply it yourself.
Yours,
Ralf S. Engelschall
[EMAIL PROTECTED]
www.engelschall.com
Index: sipsak.patch
===================================================================
RCS file: sipsak.patch
diff -N sipsak.patch
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ sipsak.patch 8 Jun 2005 18:04:46 -0000
@@ -0,0 +1,14 @@
+Index: sipsak.h
+--- sipsak.h.orig 2005-04-11 22:27:12.000000000 +0200
++++ sipsak.h 2005-06-08 19:50:50.459523361 +0200
+@@ -50,6 +50,10 @@
+ # include <string.h>
+ #endif
+
++#ifdef HAVE_NETDB_H
++#include <netdb.h>
++#endif
++
+ #ifdef HAVE_SYS_PARAM_H
+ # define FQDN_SIZE MAXHOSTNAMELEN + 1
+ #else
Index: sipsak.spec
===================================================================
RCS file: /v/openpkg/cvs/openpkg-src/sipsak/sipsak.spec,v
retrieving revision 1.1
diff -u -d -u -d -u -d -r1.1 sipsak.spec
--- sipsak.spec 8 Jun 2005 16:55:37 -0000 1.1
+++ sipsak.spec 8 Jun 2005 18:04:46 -0000
@@ -24,7 +24,7 @@
# package information
Name: sipsak
-Summary: SIP swiss army knife
+Summary: SIP Swiss Army Knife
URL: http://www.sipsak.org/
Vendor: Nils Ohlmeier
Packager: OpenPKG
@@ -37,17 +37,24 @@
# list of sources
Source0: http://download.berlios.de/sipsak/sipsak-%{version}.tar.gz
+Patch0: sipsak.patch
# build information
Prefix: %{l_prefix}
BuildRoot: %{l_buildroot}
BuildPreReq: OpenPKG, openpkg >= 20040130
PreReq: OpenPKG, openpkg >= 20040130
+BuildPreReq: openssl
+PreReq: openssl
AutoReq: no
AutoReqProv: no
%description
- sipsak is the most badly packaged program in the OpenPKG world.
+ Sipsak is a small comand line tool for developers and administrators
+ of Session Initiation Protocol (SIP) applications. It can be used
+ for some simple tests on SIP applications and devices, including
+ sending OPTIONS requests, sending text files with SIP requests,
+ traceroute, user location test, flooding test, etc.
%track
prog sipsak = {
@@ -58,12 +65,11 @@
%prep
%setup -q
+ %patch -p0
%build
CC="%{l_cc}" \
- CXX="%{l_cxx}" \
CFLAGS="%{l_cflags -O}" \
- CXXFLAGS="%{l_cxxflags -O}" \
CPPFLAGS="%{l_cppflags}" \
LDFLAGS="%{l_ldflags}" \
./configure \
______________________________________________________________________
The OpenPKG Project www.openpkg.org
Developer Communication List openpkg-dev@openpkg.org
