On Wed, Sep 13, 2006, Ralf S. Engelschall wrote:
> On Wed, Sep 13, 2006, Thomas Lotterer wrote:
>
> > do not rise privileges for "openpkg rc" when given --eval or --print
> > options; [...]
> > - else if ( strcmp(argv[i], "-q") == 0
> > + else if ( strcmp(argv[i], "-p") == 0
> > + || strcmp(argv[i], "--print") == 0
> > + || strcmp(argv[i], "-e") == 0
> > + || strcmp(argv[i], "--eval") == 0
> > + || strcmp(argv[i], "-q") == 0
> > || strcmp(argv[i], "--query") == 0
> > || strcmp(argv[i], "-c") == 0
> > || strcmp(argv[i], "--config") == 0) {
>
> Err... you are talking about --eval and -print here. That's fine. But
> you are comparing also for -e (which is "--erase"!) and -p (which is
> "--package"!) and even if this is what you really want is is done in
> the section with plain string comparisons while there is (a few lines
> below the above code) a section which deals which single-char options
> (and which already handles "-e" -- but there for "--erase" and not
> "--eval"!). So, I do not think the above is what you really intended.
Please forget everything I said. I've looked into the wrong section of
openpkg.c and overlooked that the whole stuff is wrapped with a check
for the "rc" command and not the "rpm" command (the section a few lines
above your code).
Well, seems like I've still to figure out what I need in my diet to keep
having a clue about C hacking ;-) So, just forget my comment. Everything
is ok.
Ralf S. Engelschall
[EMAIL PROTECTED]
www.engelschall.com
______________________________________________________________________
The OpenPKG Project www.openpkg.org
Developer Communication List openpkg-dev@openpkg.org
