On Tue, Oct 10, 2006, Ralf S. Engelschall wrote: >On Mon, Oct 09, 2006, Bill Campbell wrote: > >> The attached patch to the Release 2.5 version of pdflib fixes a >> problem building on SuSE Linux Enterprise 10 in which the build >> was failing saying it didn't know how to build ``-lpng''. >> >> It turns out that the included piece for the Makefile uses the >> variables PNGLIBLINK and JPEGLIBLINK in dependencies so requires >> file names here, not loader options. I put in a couple of loops >> through the l_ldflags macro to test for the libraries since on >> the 64 bit machines this may need to check multiple directories. >> >> It also required adding ``-lpng -ljpeg'' to LDFLAGS to get things >> to load properly. >> >> Looking at the pdflib.spec file in the CURRENT version of pdflib, >> it appears that it should have the same patch applied. > >Ok, now fixed in CURRENT with pdflib-7.0.0-20061010 and higher. I've >just not taken over the loop as it is not required because we explicitly >depended on _OUR_ "png", "jpeg" and "zlib" and this way we know >precisely the path to the libxxx.a file. Thanks for your contribution,
The reason I did the loops is that gcc does use create and use the %{l_prefix}/lib64 directory on 64-bit machines. While it's probably redundant, it does cover the general case and would work if there were reasons to have 32 and 64 bit libraries on a machine. Put it under the category of defensive programming if you like. Bill -- INTERNET: [EMAIL PROTECTED] Bill Campbell; Celestial Systems, Inc. UUCP: camco!bill PO Box 820; 6641 E. Mercer Way FAX: (206) 232-9186 Mercer Island, WA 98040-0820; (206) 236-1676 URL: http://www.celestial.com/ ``It will be of little avail to the people that the laws are made by men of their own choice if the laws be so voluminous that they cannot be read, or so incoherent that they cannot be understood.'' -James Madison, Federalist Paper #62 ______________________________________________________________________ The OpenPKG Project www.openpkg.org Developer Communication List openpkg-dev@openpkg.org