On Wed, Sep 20, 2006 at 04:34:23PM +0200, Ralf S. Engelschall wrote: > On Wed, Sep 20, 2006, Adam D. Morley wrote: > > > > > ... > > > > Making all in sample > > > > if /opt/openpkg/bin/cc -DHAVE_CONFIG_H -I. -I. -I.. -I../include > > > > -I/opt/openpkg/include -I/opt/openpkg/include -I/opt/openpkg/include > > > > -Wall -W -O2 -pipe -I/opt/openpkg/include -MT client.o -MD -MP -MF > > > > ".deps/client.Tpo" \ > > > > -c -o client.o `test -f 'client.c' || echo './'`client.c; \ > > > > then mv ".deps/client.Tpo" ".deps/client.Po"; \ > > > > else rm -f ".deps/client.Tpo"; exit 1; \ > > > > fi > > > > client.c: In function 'getrealm': > > > > client.c:81: warning: unused parameter 'context' > > > > client.c: In function 'simple': > > > > client.c:106: warning: unused parameter 'context' > > > > client.c: At top level: > > > > client.c:139: error: static declaration of 'getpassphrase' follows > > > > non-static declaration > > > > /usr/include/stdlib.h:206: error: previous declaration of > > > > 'getpassphrase' was here > > > > > > Yes, SASL is broken here. It Autoconf-like wrapped a getpassphrase(3) > > > function stub with "#ifndef HAVE_GETPASSPHRASE" but the whole > > > SASL doesn't have any Autoconf checks for this function. > > > This obviously breaks under platforms like Solaris where > > > the system provides a getpassphrase(3) function. Now fixed: > > > http://cvs.openpkg.org/chngview?cn=30150 > > > Thanks for the hint. > > > > Awesome. Thanks. Should I send the patch upstream to the cyrus group, > > or will you notify them that their autoconf needs another check? > > > > Also, will it show up in -CURRENT, or should I just grab the patchset > > off the web? > > The OpenPKG patch itself will not help the upstream authors as our > OpenPKG patch just axes out the incomplete "autoconfiguration" they > are using and additionally resolves a namespace conflict with a simple > rename (I've done it this way instead of adding the check as I wanted to > avoid a dependency to Autoconf). > > What the upstream author needs is a patch to their configure.ac (the > Autoconf input specification) for checking whether the getpassphrase(3) > function exists. So, it should be fully sufficient if you open a ticket > for us in the bug tracker of the upstream vendor with the hint that > their used "HAVE_GETPASSPHRASE" needs a corresponding Autoconf check and > the wish that they add such a check to their configure.ac.
Ok. I'm going to test their -current first, since I can't even create a bugzilla account with them --- it seems to be broken. Not a great sign, but they recently upgraded. -- adam ______________________________________________________________________ The OpenPKG Project www.openpkg.org User Communication List [email protected]
