> There are various places where the timeout is hard-coded. As noted in > Ian Lance-Taylor's article above, DejaGnu is far from perfect. I have > tried to fix these where I find them. If there are any places in the > Or1ksim testsuite, then they should certainly be replaced by conditional > code checking for a global value first.
I searched for "set timeout" in all *.exp files and there are very few hits. The only ones globally relevant are in or1ksim.exp and in libsim.exp. However, for some reason, those timeouts are not being taken into consideration. I would be grateful if you could remove them, as they just cause confusion. I am not skilled enough in TCL to write the conditional code you are suggesting. > Infinite timeout is a bad idea. There are some failure modes where tests > loop forever. You really don't want to lose the remaining 2400 test > results because test 100 hung. Just choose something appropriate. If we have any tests in or1ksim that should loop forever, they should set their own individual timeout values. Choosing a default timeout value for all tests is a hit-and-miss affair. For example, the 'mycompress' test alone takes hours to run if GCC is not optimising it with -O2, but that depends very much on the PC, and other tests run much faster. I would set the default test suite timeout to infinite and let the user specify something else in the command-line, in case he really wants to run as many tests as possible within say 1 hour. But I don't think they will be many people doing that with the or1ksim test suite. By the way, TCL syntax errors do not make the test suite stop with an error indication. Could you apply this patch to or1ksim? Thanks in advance, R. Diez Index: testsuite/Makefile.am =================================================================== --- testsuite/Makefile.am (Revision 783) +++ testsuite/Makefile.am (Arbeitskopie) @@ -41,6 +41,10 @@ # Setup for DejaGNU AUTOMAKE_OPTIONS = dejagnu +# Without the "--status" flag, TCL syntax or runtime errors yield a zero exit code, +# which is then taken as an indication of success (!). +AM_RUNTESTFLAGS := --status + export DEJAGNU DEJATOOL = libsim \ _______________________________________________ OpenRISC mailing list [email protected] http://lists.openrisc.net/listinfo/openrisc
