On Sat, 2012-12-22 at 09:58 +0000, Jeremy Bennett wrote: > On Sat, 2012-12-22 at 01:00 +0100, Franck Jullien wrote: > > I'm currently working on GDB updates. > > The idea is to get rid of the readspr/writespr commands to access spr > > registers. > > Hi Franck, > > This is a great piece of work. I've taken a first look through your > patches, and here are some comments.
Hi Franck, A few more comments on the complete patch set having looked through a second time. One of the key roles of OpenRISC is in education (in the widest sense), so we have tried to provide fuller commenting and description than is sometimes seen. The point is we want OpenRISC to be the architecture people turn too when they learn about GDB, or when they are documenting the tool chain. That way the widest possible user base will be familiar with our architecture. As part of this, we have used Doxygen commenting throughout, providing explanations of how each function works. It would be really good to add explanations of your new approach within this. You need to update the GDB user guide's OpenRISC section to explain the new functionality. You need to add OR32 specific tests of the new functionality. This is an area we have been dreadfully lax in historically, but we will need to do if we are ever to submit upstream to the FSF. Best wishes, Jeremy -- Tel: +44 (1590) 610184 Cell: +44 (7970) 676050 SkypeID: jeremybennett Email: [email protected] Web: www.embecosm.com _______________________________________________ OpenRISC mailing list [email protected] http://lists.openrisc.net/listinfo/openrisc
