On Thu, Mar 27, 2014 at 3:11 PM, Hesham Moustafa <[email protected]> wrote: > This other patch is for gcc also generated by git format-patch. > > The patch adds support to enable building gcc for RTEMS/or1k targets. Please > note > that RTEMS only uses newlib (without libgloss and other packaged libs). > For the previous reason, default linked libraries like or1k-sim and > or1k had to be removed. > >
Personal preference nit, send the patches with 'git send-email'. That way they get inlined into the mail and it's easier to make inline comments on them. --- a/libgcc/config.host +++ b/libgcc/config.host @@ -848,6 +848,10 @@ or1k*-*-*) tmake_file="$tmake_file or1k/t-or1k or1k/t-linux or1k/t-crtstuff t-softfp-sfdf t-softfp" extra_parts="crtbegin.o crtbeginS.o crtbeginT.o crtend.o crtendS.o crti.o crtn.o" ;; +or1k*-rtems*) + tmake_file="$tmake_file or1k/t-or1k or1k/t-linux or1k/t-crtstuff t-softfp-sfdf t-softfp" + extra_parts="crtbegin.o crtbeginS.o crtbeginT.o crtend.o crtendS.o crti.o crtn.o" + ;; pdp11-*-*) tmake_file="pdp11/t-pdp11 t-fdpbit" ;; I haven't checked what other rtems toolchains does, but is it common to use the t-linux file here? I think I've spotted t-rtems somewhere, but I might remember wrong. > On Thu, Mar 27, 2014 at 2:59 PM, Hesham Moustafa <[email protected]> > wrote: >> >> Hi, >> >> Sorry for being late. The attached patch is generated with git >> format-patch. >> Please have a look. >> >> Thanks, >> Hesham >> >> >> On Fri, Mar 21, 2014 at 8:40 PM, Hesham Moustafa >> <[email protected]> wrote: >>> >>> >>> On Mar 21, 2014 7:27 PM, "Christian Svensson" <[email protected]> wrote: >>> > >>> > Hi, >>> > >>> > On Fri, Mar 21, 2014 at 5:19 PM, Hesham Moustafa >>> > <[email protected]> wrote: >>> >> >>> >> The fixed patch is attached. I have replaced spaces by tab character. >>> > >>> > >>> > The patch looks good. >>> > >>> > If you want me to merge this with upstream (after base or1k has been >>> > merged) you will need to provide a good patch note. >>> > Look at this patch for an example: >>> > https://sourceware.org/ml/binutils/2014-03/msg00224.html - notice that the >>> > commit message explains the patch and contains the entries to be added to >>> > the ChangeLog files. >>> > If you're using git, the 'format-patch' command is a good one. >>> I am usually using git format-patch, put I had a weird problem when I >>> tried to use it with openrisc repository. Anyway, I will fix the problem and >>> submit patches again. >>> >>> Thanks >>> > >>> > Regards, >>> > Christian >>> > >> >> > _______________________________________________ OpenRISC mailing list [email protected] http://lists.openrisc.net/listinfo/openrisc
