I will push this patch tomorrow unless someone complains. I heard rumour 
that at least Lennart has tested it. :-)

regards,
Anders Widell

On 2013-06-11 10:45, Anders Widell wrote:
> Summary: uml: Update to linux 3.9.5, busybox 1.21.0, tipcutils 2.0.3 [#304]
> Review request for Trac Ticket(s): 304
> Peer Reviewer(s): Bertil
> Pull request to:
> Affected branch(es): opensaf-4.2.x, opensaf-4.3.x, default(4.4)
> Development branch: default
>
> --------------------------------
> Impacted area       Impact y/n
> --------------------------------
>   Docs                    n
>   Build system            n
>   RPM/packaging           n
>   Configuration files     n
>   Startup scripts         n
>   SAF services            n
>   OpenSAF services        n
>   Core libraries          n
>   Samples                 n
>   Tests                   n
>   Other                   y
>
>
> Comments (indicate scope for each "y" above):
> ---------------------------------------------
> changeset 6548ed5dcb2d5b07d79c2f3df771af35efdf6763
> Author:       Anders Widell <[email protected]>
> Date: Tue, 11 Jun 2013 10:40:27 +0200
>
>       uml: Update to linux 3.9.5, busybox 1.21.0, tipcutils 2.0.3 [#304]
>
>       Update the UML environment so that it builds on Ubuntu 13.04 and Fedora 
> 18.
>       Also did the following improvements:
>
>       * Added a new environment variable OSAF_UML_MEMSIZE that can be used to
>       specify how much memory to allocate for each blade.
>       * Fixed the configuration of LOG to use a shared director so that it 
> works
>       also when the LOG root directory is configured via an IMM object.
>
>
> Complete diffstat:
> ------------------
>   tools/cluster_sim_uml/README                        |     4 +
>   tools/cluster_sim_uml/build_uml                     |    15 +-
>   tools/cluster_sim_uml/opensaf                       |     3 +-
>   tools/cluster_sim_uml/uml/build_uml                 |    68 ++----
>   tools/cluster_sim_uml/uml/config/busybox-1.15.2     |   899 
> ------------------------------------------------------------------------------------------------------
>   tools/cluster_sim_uml/uml/config/busybox-1.21.0     |  1022 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   tools/cluster_sim_uml/uml/config/linux-2.6.31-i686  |   736 
> ------------------------------------------------------------------------------------
>   tools/cluster_sim_uml/uml/config/linux-3.9.5-i686   |   980 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   tools/cluster_sim_uml/uml/config/linux-3.9.5-x86_64 |   971 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   9 files changed, 3016 insertions(+), 1682 deletions(-)
>
>
> Testing Commands:
> -----------------
> Build and start UML on Ubuntu 13.04
>
>
> Testing, Expected Results:
> --------------------------
> UML should build and start successfully.
>
>
> Conditions of Submission:
> -------------------------
>   <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
>
>
> Arch      Built     Started    Linux distro
> -------------------------------------------
> mips        n          n
> mips64      n          n
> x86         n          n
> x86_64      y          y
> powerpc     n          n
> powerpc64   n          n
>
>
> Reviewer Checklist:
> -------------------
> [Submitters: make sure that your review doesn't trigger any checkmarks!]
>
>
> Your checkin has not passed review because (see checked entries):
>
> ___ Your RR template is generally incomplete; it has too many blank entries
>      that need proper data filled in.
>
> ___ You have failed to nominate the proper persons for review and push.
>
> ___ Your patches do not have proper short+long header
>
> ___ You have grammar/spelling in your header that is unacceptable.
>
> ___ You have exceeded a sensible line length in your headers/comments/text.
>
> ___ You have failed to put in a proper Trac Ticket # into your commits.
>
> ___ You have incorrectly put/left internal data in your comments/files
>      (i.e. internal bug tracking tool IDs, product names etc)
>
> ___ You have not given any evidence of testing beyond basic build tests.
>      Demonstrate some level of runtime or other sanity testing.
>
> ___ You have ^M present in some of your files. These have to be removed.
>
> ___ You have needlessly changed whitespace or added whitespace crimes
>      like trailing spaces, or spaces before tabs.
>
> ___ You have mixed real technical changes with whitespace and other
>      cosmetic code cleanup changes. These have to be separate commits.
>
> ___ You need to refactor your submission into logical chunks; there is
>      too much content into a single commit.
>
> ___ You have extraneous garbage in your review (merge commits etc)
>
> ___ You have giant attachments which should never have been sent;
>      Instead you should place your content in a public tree to be pulled.
>
> ___ You have too many commits attached to an e-mail; resend as threaded
>      commits, or place in a public tree for a pull.
>
> ___ You have resent this content multiple times without a clear indication
>      of what has changed between each re-send.
>
> ___ You have failed to adequately and individually address all of the
>      comments and change requests that were proposed in the initial review.
>
> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
>
> ___ Your computer have a badly configured date and time; confusing the
>      the threaded patch review.
>
> ___ Your changes affect IPC mechanism, and you don't present any results
>      for in-service upgradability test.
>
> ___ Your changes affect user manual and documentation, your patch series
>      do not contain the patch that updates the Doxygen manual.
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Opensaf-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
>
>


------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to