I think the commit messages are confusing since the old 3.0 source structure still remain. I think we should change that. But for now I think the commit messages should start with the subcomponent name like just like as if the source structure is has been changed. Like "amfd: <verb>" or "amfnd: <verb>"
And we should never mix amfd and amfnd changes in the same changeset! So instead of "amf: handle ... at amfnd [#98]" we get "amfnd: handle ... [#98] Thanks, Hans On 7 June 2013 08:39, <[email protected]> wrote: > Summary: amf: support for saAmfSUFailover [#98]. > Review request for Trac Ticket(s): #98 > Peer Reviewer(s): Hans F., Nagendra, Mathivanan, Anders W., Hans N. > Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> > Affected branch(es): default > Development branch: <<IF ANY GIVE THE REPO URL>> > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > These six patches provides support for saAmfSUFailover. Please see below > description of > each patch: > > changeset f8ef0605cde806b248549a9a000f8de3a80f0cbe > Author: [email protected] > Date: Fri, 07 Jun 2013 11:44:36 +0530 > > amf: handle ccb modify op on attr saAmfSutDefSUFailover and > saAmfSUFailover > at amfd [#98] The patch allows modify operation on attribute > saAmfSutDefSUFailover of class SaAmfSUType. Modificaion of > saAmfSUFailover > in SaAmfSU is allowed only when SG is stable. > > changeset 41d11e667685fcae335117f756131c683d5af9ac > Author: [email protected] > Date: Fri, 07 Jun 2013 11:47:27 +0530 > > amf: handle ccb modify op on attr saAmfSgtDefAutoRepair at amfd > [#98] The > patch allows ccb modify operation on attribute > saAmfSGDefAutoRepair of class > SaAmfSGType and saAmfSgAutoRepair of class SaAmfSG. > > changeset c1765e829834a3d9d7b6e10825e5d687fe863412 > Author: [email protected] > Date: Fri, 07 Jun 2013 11:49:42 +0530 > > amf: failover of assignments during sufailover and repair of > faulted SU at > amfd [#98] This patch separates sufailover and compfailover at > amfd. > Currently suFailover will be supported only for 2N and NoRed > model. During > compfailover, switchover of assignments will be done through > quiesced HA > state. In case of sufailover, amfd will perform failover by giving > active to > the standby SU in 2N model. For NoRed model spare SU will be made > active. > Repair of faulted SU will be performed if saAmfSgAutoRepair is > enabled. > > changeset 9c1dc46e69ae3b4d6dd18474dede894cf275af7e > Author: [email protected] > Date: Fri, 07 Jun 2013 11:51:30 +0530 > > amf: mainatain saAmfSUFailover and reg_model of SU at amfnd [#98] > With this > patch amfnd will maintain the red model of SU and also > saAmfSUFailover > attribute of SU. Amfnd will read them from IMM before any > instantiation of > SU. > > changeset 9e581a8d70bf34c33edc5bb76ac15219a6423a4f > Author: [email protected] > Date: Fri, 07 Jun 2013 11:53:38 +0530 > > amf: support sufailover at amfnd [#98] This patch handles > compfailover and > sufailover in comformance with the AMF-B.04.01 spec at amfnd. > Currently only > 2N model and NoRed models are supported. For other models, > saAmfSUFailover > will be ignored and compFailover will be performed. During > suFailover SU > will be disabled and all comps will be abruptly terminated. Also > handles the > case when saAmfSUFailover is true and Nodswitchover gets escalated. > > changeset 77a47a7b1157bfc27b6d64d732c2f2d798c20322 > Author: [email protected] > Date: Fri, 07 Jun 2013 11:55:11 +0530 > > amf: handle sufailover in SU FSM and Comp FSM at amfnd [#98] With > this > patch amfnd informs amfd for failover of assignments when all > components are > terminated successfully during suFailover. If some component > faults and SU > moves to inst/term failed state, compFailover will be performed. > > > Complete diffstat: > ------------------ > osaf/libs/common/avsv/avsv_util.c | 28 +++++++ > osaf/libs/common/avsv/include/avsv_util.h | 1 + > osaf/services/saf/avsv/avd/avd_clm.cc | 1 + > osaf/services/saf/avsv/avd/avd_comp.cc | 9 +- > osaf/services/saf/avsv/avd/avd_node.cc | 7 +- > osaf/services/saf/avsv/avd/avd_sg.cc | 35 +++++++- > osaf/services/saf/avsv/avd/avd_sgproc.cc | 231 > ++++++++++++++++++++++++++++++++++++++++++++++++++--------- > osaf/services/saf/avsv/avd/avd_sgtype.cc | 114 > +++++++++++++++++++++++++++++- > osaf/services/saf/avsv/avd/avd_su.cc | 80 +++++++++++++++++++- > osaf/services/saf/avsv/avd/avd_sutype.cc | 104 > ++++++++++++++++++++++++++- > osaf/services/saf/avsv/avd/include/avd_proc.h | 2 + > osaf/services/saf/avsv/avd/include/avd_sg.h | 3 +- > osaf/services/saf/avsv/avd/include/avd_su.h | 2 + > osaf/services/saf/avsv/avnd/avnd_clc.c | 130 > ++++++++++++++++++++++++--------- > osaf/services/saf/avsv/avnd/avnd_comp.c | 2 +- > osaf/services/saf/avsv/avnd/avnd_compdb.c | 1 + > osaf/services/saf/avsv/avnd/avnd_err.c | 150 > ++++++++++++++++++++++++++------------ > osaf/services/saf/avsv/avnd/avnd_su.c | 1 + > osaf/services/saf/avsv/avnd/avnd_sudb.c | 79 ++++++++++++++++++++ > osaf/services/saf/avsv/avnd/avnd_susm.c | 81 ++++++++++++++------ > osaf/services/saf/avsv/avnd/include/avnd_su.h | 7 + > 21 files changed, 899 insertions(+), 169 deletions(-) > > > Testing Commands: > ----------------- > Test: > In TwoN model below mentioned recoveries tested in PI SU and NPI SU by > killing assigned comp: > 1)comprestart > 2)compFailover > 3)suFailover by enabling saAmfSUFailover, enabling saAmfCompDisableRestart > and enabling saAmfCompRecoveryOnError. > 4)Nodeswitchover when saAmfFailover is true. If node has SU of other app > also then it should perform > switchover of that su. This case also tested. > 5)NodeFailover. > 6)Also tested in sufailover, whether AMF is performing repair of faulted > SU when saAmfSgAutoRepair=1. > > Also tested admin operations lock/lock-in/unlock/shutdown/si-swap on > Node,SU,SG or SI. > > In NoRed compFailover and SUFailover is tested in PI SU. > > Testing is still going on....... > > Testing, Expected Results: > -------------------------- > All above mentioned tests pass. > > Conditions of Submission: > ------------------------- > Ack from atleat three reviewers. > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 y y > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > > ------------------------------------------------------------------------------ > How ServiceNow helps IT people transform IT departments: > 1. A cloud service to automate IT design, transition and operations > 2. Dashboards that offer high-level views of enterprise services > 3. A single system of record for all IT processes > http://p.sf.net/sfu/servicenow-d2d-j > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
