Summary: amf: support for saAmfSUFailover [#98]. Review request for Trac Ticket(s): amf #98 Peer Reviewer(s): Hans F., Nagendra, Mathivanan Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es):default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Refloating the patches after implementing comments. changeset d27ddf056d171278a352aa310f4d5ab5f111d1d3 Author: [email protected] Date: Fri, 28 Jun 2013 11:31:06 +0530 amfd: handle ccb modify op on attr saAmfSutDefSUFailover and saAmfSUFailover at amfd [#98] Refloating the patch after incorporating comments. changeset 28e91fafe42f070db96d119658b22fc76c6858ed Author: [email protected] Date: Fri, 28 Jun 2013 11:32:55 +0530 amfd: handle ccb modify op on attr saAmfSgtDefAutoRepair [#98] Refloating the patch after incorporating comments. changeset ef48344b350e6856d9d4aab18707da216c924c29 Author: [email protected] Date: Fri, 28 Jun 2013 11:38:03 +0530 amfd: failover of assignments during sufailover and repair of faulted SU [#98] Refloating the patch after incorporating comments. changeset bc70d7601eb05a97ae58372a5edc0f55193be69e Author: [email protected] Date: Fri, 28 Jun 2013 11:40:34 +0530 amfnd: handle sufailover in SU FSM and Comp FSM [#98] Refloating the patch after incorporating comments. Complete diffstat: ------------------ osaf/services/saf/avsv/avd/avd_clm.cc | 1 + osaf/services/saf/avsv/avd/avd_comp.cc | 9 +- osaf/services/saf/avsv/avd/avd_node.cc | 7 +- osaf/services/saf/avsv/avd/avd_sg.cc | 34 ++++- osaf/services/saf/avsv/avd/avd_sgproc.cc | 371 +++++++++++++++++++++++++++++++++++++---------------------- osaf/services/saf/avsv/avd/avd_sgtype.cc | 106 ++++++++++++++++- osaf/services/saf/avsv/avd/avd_su.cc | 88 ++++++++++++- osaf/services/saf/avsv/avd/avd_sutype.cc | 92 ++++++++++++++- osaf/services/saf/avsv/avd/include/avd_proc.h | 3 + osaf/services/saf/avsv/avd/include/avd_sg.h | 3 +- osaf/services/saf/avsv/avd/include/avd_su.h | 4 +- osaf/services/saf/avsv/avnd/avnd_clc.c | 82 +++++++----- osaf/services/saf/avsv/avnd/avnd_comp.c | 2 +- osaf/services/saf/avsv/avnd/avnd_su.c | 1 + osaf/services/saf/avsv/avnd/avnd_susm.c | 127 +++++++++++++++---- 15 files changed, 695 insertions(+), 235 deletions(-) Testing Commands: ----------------- Compfailover, sufailover for PI and sufailover for NPI. Testing, Expected Results: -------------------------- PASS Conditions of Submission: ------------------------- Ack from Hans and Nagendra. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 y y x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
