Summary: amfnd: report failover after comp cleanup Review request for Trac Ticket(s): 474 Peer Reviewer(s): Nagendra Pull request to: Nagendra Affected branch(es): all Development branch: staging
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 85b149a61c4c41789b547857494157f2c2c2d4e9 Author: Hans Feldt <[email protected]> Date: Thu, 04 Jul 2013 16:21:54 +0200 amfnd: report failover after comp cleanup [#474] Component failover was previously reported to the AMF director at the same time as the cleanup script was launched. This could give the consequence that activation of the new SU was done even before the cleanup had started. Especially if there was no other SU to failover the SI to. With this patch, the outcome of cleanup is awaited before the AMF director is informed. This gives a cleaner and deterministic behavior and no parallelism. NPI components are handled the same (faulty?) way as before. The failover is started when the SUSI MOD QUIESCED request is received. Components marked as failed will be cleaned up and healthy ones terminated. If yet another component fails in the same SU, there can potentially be another "oper state msg" send to the director. There is no change in behaviour with this patch. Complete diffstat: ------------------ osaf/services/saf/avsv/avnd/avnd_clc.c | 16 ++++++++++++++++ osaf/services/saf/avsv/avnd/avnd_err.c | 10 ++++------ 2 files changed, 20 insertions(+), 6 deletions(-) Testing Commands: ----------------- PI SU with 3 PI comps, 2N SG report error with rec rec "comp failover" verify cleanup of failed comp happens first verify other comps are quiesced and terminated verify failover NPI SU with 3 comps, 2N SG report error with rec rec "comp failover" verify failed comp is cleand, healthy comps are quiesced and terminated verify failover Some other regression tests Testing, Expected Results: -------------------------- OK Conditions of Submission: ------------------------- Ack from Nags (and pull request) Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y ubuntu12.10 powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
