Summary:amfnd: failover of PI SU having NPI component[#504]. Review request for Trac Ticket(s): amf #504 Peer Reviewer(s): Hans N., Nagendra, Hans F Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es):Default Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Please see the commit message log and ticket. changeset 3ca5653771660d5d83b33ce91d81328ccca615ae Author: [email protected] Date: Mon, 22 Jul 2013 17:19:17 +0530 amfnd: failover of PI SU having NPI component[#504] If SU is PI with no NPI component or If SU is NPI then SU FSM is always triggered when SU is in terminating state and one of the components gets terminated successfully. But if PI SU has atleast one NPI component, then SU FSM is not triggered when NPI component gets successfully terminated. This patch ensures that successful termination of NPI component in PI SU should trigger SU FSM. Complete diffstat: ------------------ osaf/services/saf/avsv/avnd/avnd_clc.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Testing Commands: ----------------- Tested the configurations given by reporter and sample amf demo configuration updated in the ticket. Testing, Expected Results: -------------------------- SU failover is performed by AMF. Conditions of Submission: ------------------------- Ack from atleast one reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 y y x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
