Summary:amfd: update assignment counters when component faults during shutdown op [#307] Review request for Trac Ticket(s):amf #307 Peer Reviewer(s): Hans F, Nagendra, Hans N. Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Please see the ticket and commit log below for changes. changeset 66a7f91902597cb42de22de944c3754dd4e5cb9c Author: [email protected] Date: Tue, 23 Jul 2013 18:01:05 +0530 amfd: update assignment counters when component faults during shutdown op [#307] Unlike active, quiesced and standby HA states, assignment counters in quiescing HA state are updated when AMFD receives assignment response from AMFND. If a component faults with sufailover or nodefailover recovery when shutdown operation is in progress then AMFD will not receive assignment response from AMFND. This patch will update assignment counters when component fault leads to sufailover of nodefailover during shutdown operation. Complete diffstat: ------------------ osaf/services/saf/avsv/avd/avd_sgproc.cc | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) Testing Commands: ----------------- Tested with the configuration uploaded in the ticket (AppConfig-2N.xml_307) 1)#307 2)#482 3)#487 4)#489 5)Nodefailover recovery during shutdown operation by hosting active SU on active controller. 6)sufailover recovery during shutdown operation on active SU Testing, Expected Results: -------------------------- Not observing PARTIALLY_ASSIGNED state or assert due to mismatch of assignment counters. Conditions of Submission: ------------------------- Ack from atleast one reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 y y x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
