Summary: logsv: Fix hanging main thread when file i/o don't return Review request for Trac Ticket(s): #9 Peer Reviewer(s): Madhurika Koppula, (Anders Widell, Hans Feldt) Pull request to: NA Affected branch(es): devel (4.4) Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Add to patches in previous review requests In order to protect the log server "main thread" (MT) from hanging if a file operation like write, mkdir etc. does not return, all such operations are done in a separate "file thread" (FT). Functions running in the "Main Thread" (MT) that needs file system operations handle over the execution to the FT when file handling has to be done. Execution is then given back to the MT again. If a file operation does not return FT will hang but MT will time out the FT and resume. A timeout will be handled as a file operation fail. The MT can detect if the FT is hanging and new requests for file operations will be "failed". changeset 08230033c53cbb2998b9e8406efec47f337fff46 Author: Lennart Lund <[email protected]> Date: Mon, 12 Aug 2013 16:02:40 +0200 logsv: Fix hanging main thread when file i/o don't return. [#9]. Part 12 - Make timeouts for file hdl configurable in Log service configuration object Complete diffstat: ------------------ osaf/services/saf/logsv/README | 7 +++++-- osaf/services/saf/logsv/config/logsv_classes.xml | 14 ++++++++++++++ osaf/services/saf/logsv/lgs/lgs.h | 2 ++ osaf/services/saf/logsv/lgs/lgs_file.c | 45 ++++++++++++++++++++++++++++++++------------- osaf/services/saf/logsv/lgs/lgs_imm.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++----- 5 files changed, 103 insertions(+), 20 deletions(-) Testing Commands: ----------------- See previous review requests Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
