Ack.
Tested :
1) Applied patch1 and then renamed paths manually by using "hg rename".
After this applied rest of the patches.
Build and brought up controller.
2) make distclean, hg update 4.3 and then recompile.
Thanks,
Praveen
On 26-Aug-13 6:01 PM, Hans Feldt wrote:
> It is not entirely wrong, SA-Forum talks about both AMF and SMF as a service
> in the "CPROG" document and specifies the DN:
> * Availability Management Framework "safApp=safAmfService"
>
> So we could use "amfsv" but "amf" is shorter and sweeter.
>
> So agree, "amf" it is.
>
> Do I have an ack?
>
> Thanks,
> Hans
>
>> -----Original Message-----
>> From: praveen malviya [mailto:[email protected]]
>> Sent: den 26 augusti 2013 08:51
>> To: Hans Feldt
>> Cc: [email protected]
>> Subject: Re: [PATCH 0 of 5] Review Request for amfsv #533
>>
>> I think word "service" is not used for AMF and SMF. So instead of
>> renaming "avsv" to "amfsv", can it be renamed to "amf"?
>>
>> Thanks,
>> Praveen
>> On 23-Aug-13 6:28 PM, Hans Feldt wrote:
>>> Summary: rename avsv
>>> Review request for Trac Ticket(s): 533
>>> Peer Reviewer(s): Praveen & Nags
>>> Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
>>> Affected branch(es): default
>>> Development branch: default
>>>
>>> --------------------------------
>>> Impacted area Impact y/n
>>> --------------------------------
>>> Docs n
>>> Build system y
>>> RPM/packaging n
>>> Configuration files n
>>> Startup scripts n
>>> SAF services n
>>> OpenSAF services n
>>> Core libraries n
>>> Samples n
>>> Tests n
>>> Other n
>>>
>>>
>>> Comments (indicate scope for each "y" above):
>>> ---------------------------------------------
>>>
>>> changeset 1abf7f5a01dbf7d2936c2bb55ac711fec55e7f90
>>> Author: Hans Feldt <[email protected]>
>>> Date: Fri, 23 Aug 2013 14:44:51 +0200
>>>
>>> rename avsv to amfsv [#533]
>>>
>>> In order to align AMF specification, ticket system and source code the
>>> avsv
>>> name is with this patch changed to amfsv. avsv is a relic from opensaf3
>>> and
>>> earlier where avsv contained both clm and amf.
>>>
>>> changeset fa172b7214fec6d20c3ea85049a71967f149faa7
>>> Author: Hans Feldt <[email protected]>
>>> Date: Fri, 23 Aug 2013 14:45:32 +0200
>>>
>>> amfsv: rename libavsv_common to libamfsv_common [#533]
>>>
>>> changeset f768c5f9650aa9a6c7919bab111072d5450a79fd
>>> Author: Hans Feldt <[email protected]>
>>> Date: Fri, 23 Aug 2013 14:47:10 +0200
>>>
>>> amfsv: rename common lib files [533]
>>>
>>> changeset 0445048b508dd303f2cbd6c238852ea2999a437d
>>> Author: Hans Feldt <[email protected]>
>>> Date: Fri, 23 Aug 2013 14:47:22 +0200
>>>
>>> amfsv: rename avsv xml files [#533]
>>>
>>> changeset 308d79cca35f9d1b274552ad962088804214debc
>>> Author: Hans Feldt <[email protected]>
>>> Date: Fri, 23 Aug 2013 14:49:56 +0200
>>>
>>> amfsv: remove avsv tests [#533]
>>>
>>>
>>> Complete diffstat:
>>> ------------------
>>> configure.ac | 34
>>> +++++++++++++++++-----------------
>>> osaf/libs/agents/saf/Makefile.am | 2 +-
>>> osaf/libs/agents/saf/ava/Makefile.am | 5 ++---
>>> osaf/libs/agents/saf/ava/ava_api.c | 0
>>> osaf/libs/agents/saf/ava/ava_hdl.c | 0
>>> osaf/libs/agents/saf/ava/ava_init.c | 0
>>> osaf/libs/agents/saf/ava/ava_mds.c | 0
>>> osaf/libs/agents/saf/ava/ava_op.c | 0
>>> osaf/libs/agents/saf/ava/include/Makefile.am | 0
>>> osaf/libs/agents/saf/ava/include/ava.h | 8 ++++----
>>> osaf/libs/agents/saf/ava/include/ava_cb.h | 0
>>> osaf/libs/agents/saf/ava/include/ava_def.h | 0
>>> osaf/libs/agents/saf/ava/include/ava_dl_api.h | 0
>>> osaf/libs/agents/saf/ava/include/ava_hdl.h | 0
>>> osaf/libs/agents/saf/ava/include/ava_mds.h | 0
>>> osaf/libs/common/Makefile.am | 2 +-
>>> osaf/libs/common/avsv/Makefile.am | 23
>>> +++++++++++------------
>>> osaf/libs/common/avsv/avsv_d2nedu.c | 8 ++++----
>>> osaf/libs/common/avsv/avsv_d2nmsg.c | 4 ++--
>>> osaf/libs/common/avsv/avsv_eduutil.c | 6 +++---
>>> osaf/libs/common/avsv/include/Makefile.am | 22
>>> +++++++++++-----------
>>> osaf/libs/common/avsv/include/avsv.h | 6 +++---
>>> osaf/libs/common/avsv/include/avsv_amfparam.h | 0
>>> osaf/libs/common/avsv/include/avsv_d2nedu.h | 0
>>> osaf/libs/common/avsv/include/avsv_d2nmsg.h | 2 +-
>>> osaf/libs/common/avsv/include/avsv_defs.h | 0
>>> osaf/libs/common/avsv/include/avsv_eduutil.h | 0
>>> osaf/libs/common/avsv/include/avsv_ipc.h | 0
>>> osaf/libs/common/avsv/include/avsv_n2avaedu.h | 0
>>> osaf/libs/common/avsv/include/avsv_n2avamsg.h | 0
>>> osaf/libs/common/avsv/include/avsv_nd2ndmsg.h | 2 +-
>>> osaf/libs/common/avsv/include/avsv_util.h | 2 +-
>>> osaf/libs/common/avsv/avsv_n2avaedu.c | 10 +++++-----
>>> osaf/libs/common/avsv/avsv_n2avamsg.c | 8 ++++----
>>> osaf/libs/common/avsv/avsv_nd2ndedu.c | 14
>>> +++++++-------
>>> osaf/libs/common/avsv/avsv_util.c | 2 +-
>>> osaf/libs/saf/libSaAmf/Makefile.am | 7 +++----
>>> osaf/services/saf/Makefile.am | 2 +-
>>> osaf/services/saf/avsv/Makefile.am | 2 +-
>>> osaf/services/saf/avsv/avd/Makefile.am | 6 +++---
>>> osaf/services/saf/avsv/avd/amfd_main.cc | 0
>>> osaf/services/saf/avsv/avd/avd.cc | 0
>>> osaf/services/saf/avsv/avd/avd_app.cc | 0
>>> osaf/services/saf/avsv/avd/avd_apptype.cc | 0
>>> osaf/services/saf/avsv/avd/avd_chkop.cc | 0
>>> osaf/services/saf/avsv/avd/avd_ckpt_dec.cc | 0
>>> osaf/services/saf/avsv/avd/avd_ckpt_edu.cc | 2 +-
>>> osaf/services/saf/avsv/avd/avd_ckpt_enc.cc | 0
>>> osaf/services/saf/avsv/avd/avd_ckpt_updt.cc | 0
>>> osaf/services/saf/avsv/avd/avd_clm.cc | 0
>>> osaf/services/saf/avsv/avd/avd_cluster.cc | 0
>>> osaf/services/saf/avsv/avd/avd_comp.cc | 2 +-
>>> osaf/services/saf/avsv/avd/avd_compcstype.cc | 2 +-
>>> osaf/services/saf/avsv/avd/avd_comptype.cc | 2 +-
>>> osaf/services/saf/avsv/avd/avd_csi.cc | 2 +-
>>> osaf/services/saf/avsv/avd/avd_csiattr.cc | 2 +-
>>> osaf/services/saf/avsv/avd/avd_cstype.cc | 0
>>> osaf/services/saf/avsv/avd/avd_ctcstype.cc | 0
>>> osaf/services/saf/avsv/avd/avd_dmsg.cc | 0
>>> osaf/services/saf/avsv/avd/avd_hlt.cc | 2 +-
>>> osaf/services/saf/avsv/avd/avd_hlttype.cc | 0
>>> osaf/services/saf/avsv/avd/avd_imm.cc | 2 +-
>>> osaf/services/saf/avsv/avd/avd_mds.cc | 0
>>> osaf/services/saf/avsv/avd/avd_ndfsm.cc | 0
>>> osaf/services/saf/avsv/avd/avd_ndmsg.cc | 0
>>> osaf/services/saf/avsv/avd/avd_ndproc.cc | 0
>>> osaf/services/saf/avsv/avd/avd_node.cc | 0
>>> osaf/services/saf/avsv/avd/avd_nodegroup.cc | 0
>>> osaf/services/saf/avsv/avd/avd_nodeswbundle.cc | 0
>>> osaf/services/saf/avsv/avd/avd_ntf.cc | 0
>>> osaf/services/saf/avsv/avd/avd_pg.cc | 0
>>> osaf/services/saf/avsv/avd/avd_proc.cc | 0
>>> osaf/services/saf/avsv/avd/avd_role.cc | 0
>>> osaf/services/saf/avsv/avd/avd_sg.cc | 0
>>> osaf/services/saf/avsv/avd/avd_sg2Nfsm.cc | 0
>>> osaf/services/saf/avsv/avd/avd_sgNAcvRfsm.cc | 0
>>> osaf/services/saf/avsv/avd/avd_sgNWayfsm.cc | 0
>>> osaf/services/saf/avsv/avd/avd_sgNoRfsm.cc | 0
>>> osaf/services/saf/avsv/avd/avd_sgNpMfsm.cc | 0
>>> osaf/services/saf/avsv/avd/avd_sgproc.cc | 0
>>> osaf/services/saf/avsv/avd/avd_sgtype.cc | 0
>>> osaf/services/saf/avsv/avd/avd_si.cc | 0
>>> osaf/services/saf/avsv/avd/avd_siDep.cc | 0
>>> osaf/services/saf/avsv/avd/avd_siass.cc | 2 +-
>>> osaf/services/saf/avsv/avd/avd_sirankedsu.cc | 2 +-
>>> osaf/services/saf/avsv/avd/avd_su.cc | 0
>>> osaf/services/saf/avsv/avd/avd_sutcomptype.cc | 0
>>> osaf/services/saf/avsv/avd/avd_sutype.cc | 0
>>> osaf/services/saf/avsv/avd/avd_svctype.cc | 0
>>> osaf/services/saf/avsv/avd/avd_svctypecstypes.cc | 0
>>> osaf/services/saf/avsv/avd/avd_tmr.cc | 0
>>> osaf/services/saf/avsv/avd/avd_util.cc | 0
>>> osaf/services/saf/avsv/avd/include/Makefile.am | 0
>>> osaf/services/saf/avsv/avd/include/avd.h | 8 ++++----
>>> osaf/services/saf/avsv/avd/include/avd_app.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_cb.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_ckp.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_ckpt_edu.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_ckpt_msg.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_ckpt_updt.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_clm.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_cluster.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_comp.h | 2 +-
>>> osaf/services/saf/avsv/avd/include/avd_csi.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_def.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_dl_api.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_evt.h | 2 +-
>>> osaf/services/saf/avsv/avd/include/avd_hlt.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_imm.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_mds.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_msg.h | 2 +-
>>> osaf/services/saf/avsv/avd/include/avd_node.h | 2 +-
>>> osaf/services/saf/avsv/avd/include/avd_ntf.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_pg.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_proc.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_sg.h | 4 ++--
>>> osaf/services/saf/avsv/avd/include/avd_si.h | 2 +-
>>> osaf/services/saf/avsv/avd/include/avd_si_dep.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_su.h | 2 +-
>>> osaf/services/saf/avsv/avd/include/avd_susi.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_sutype.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_tmr.h | 0
>>> osaf/services/saf/avsv/avd/include/avd_util.h | 4 ++--
>>> osaf/services/saf/avsv/avd/scripts/Makefile.am | 2 +-
>>> osaf/services/saf/avsv/avd/scripts/osaf-amfd.in | 0
>>> osaf/services/saf/avsv/avnd/Makefile.am | 8 ++++----
>>> osaf/services/saf/avsv/avnd/amfnd_main.c | 0
>>> osaf/services/saf/avsv/avnd/avnd.c | 6 +++---
>>> osaf/services/saf/avsv/avnd/avnd_avnd.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_cam.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_cbq.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_chc.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_ckpt_dec.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_ckpt_edu.c | 6 +++---
>>> osaf/services/saf/avsv/avnd/avnd_ckpt_enc.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_ckpt_updt.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_clc.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_clm.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_comp.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_compdb.c | 2 +-
>>> osaf/services/saf/avsv/avnd/avnd_cpm.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_di.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_err.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_evt.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_hcdb.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_mbcsv.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_mds.c | 4 ++--
>>> osaf/services/saf/avsv/avnd/avnd_mon.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_pg.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_pgdb.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_proc.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_proxy.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_proxydb.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_sidb.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_su.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_sudb.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_susm.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_term.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_tmr.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_util.c | 0
>>> osaf/services/saf/avsv/avnd/avnd_verify.c | 0
>>> osaf/services/saf/avsv/avnd/include/Makefile.am | 0
>>> osaf/services/saf/avsv/avnd/include/avnd.h | 12 ++++++------
>>> osaf/services/saf/avsv/avnd/include/avnd_cb.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_ckpt_edu.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_ckpt_msg.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_ckpt_updt.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_clm.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_comp.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_def.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_defs.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_di.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_dl_api.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_err.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_evt.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_hc.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_mbcsv.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_mds.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_mon.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_pg.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_proc.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_proxy.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_su.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_tmr.h | 0
>>> osaf/services/saf/avsv/avnd/include/avnd_util.h | 0
>>> osaf/services/saf/avsv/avnd/scripts/Makefile.am | 2 +-
>>> osaf/services/saf/avsv/avnd/scripts/osaf-amfnd.in | 0
>>> osaf/services/saf/avsv/amfwdog/Makefile.am | 0
>>> osaf/services/saf/avsv/amfwdog/amf_wdog.c | 0
>>> osaf/services/saf/avsv/amfwdog/scripts/Makefile.am | 2 +-
>>> osaf/services/saf/avsv/amfwdog/scripts/osaf-amfwd.in | 0
>>> osaf/services/saf/avsv/config/Makefile.am | 10 +++++-----
>>> osaf/services/saf/avsv/config/amfd.conf | 0
>>> osaf/services/saf/avsv/config/amfnd.conf | 0
>>> osaf/services/saf/avsv/config/avsv_classes.xml | 0
>>> osaf/services/saf/avsv/config/avsv_objects.xml | 0
>>> osaf/services/saf/avsv/config/amfwdog.conf | 0
>>> osaf/services/saf/avsv/config/amfwdog_objects.xml | 0
>>> osaf/services/saf/avsv/config/amfwdog_pl_template.xml | 0
>>> osaf/services/saf/avsv/config/amfwdog_sc_template.xml | 0
>>> osaf/services/saf/avsv/config/common_pl_template.xml | 0
>>> osaf/services/saf/avsv/config/common_sc_template.xml | 0
>>> 202 files changed, 138 insertions(+), 141 deletions(-)
>>>
>>>
>>> Testing Commands:
>>> -----------------
>>> Build opensaf
>>>
>>>
>>> Testing, Expected Results:
>>> --------------------------
>>> Builds
>>>
>>>
>>> Conditions of Submission:
>>> -------------------------
>>> ack from Praveen
>>>
>>>
>>> Arch Built Started Linux distro
>>> -------------------------------------------
>>> mips n n
>>> mips64 n n
>>> x86 n n
>>> x86_64 y y
>>> powerpc n n
>>> powerpc64 n n
>>>
>>>
>>> Reviewer Checklist:
>>> -------------------
>>> [Submitters: make sure that your review doesn't trigger any checkmarks!]
>>>
>>>
>>> Your checkin has not passed review because (see checked entries):
>>>
>>> ___ Your RR template is generally incomplete; it has too many blank entries
>>> that need proper data filled in.
>>>
>>> ___ You have failed to nominate the proper persons for review and push.
>>>
>>> ___ Your patches do not have proper short+long header
>>>
>>> ___ You have grammar/spelling in your header that is unacceptable.
>>>
>>> ___ You have exceeded a sensible line length in your headers/comments/text.
>>>
>>> ___ You have failed to put in a proper Trac Ticket # into your commits.
>>>
>>> ___ You have incorrectly put/left internal data in your comments/files
>>> (i.e. internal bug tracking tool IDs, product names etc)
>>>
>>> ___ You have not given any evidence of testing beyond basic build tests.
>>> Demonstrate some level of runtime or other sanity testing.
>>>
>>> ___ You have ^M present in some of your files. These have to be removed.
>>>
>>> ___ You have needlessly changed whitespace or added whitespace crimes
>>> like trailing spaces, or spaces before tabs.
>>>
>>> ___ You have mixed real technical changes with whitespace and other
>>> cosmetic code cleanup changes. These have to be separate commits.
>>>
>>> ___ You need to refactor your submission into logical chunks; there is
>>> too much content into a single commit.
>>>
>>> ___ You have extraneous garbage in your review (merge commits etc)
>>>
>>> ___ You have giant attachments which should never have been sent;
>>> Instead you should place your content in a public tree to be pulled.
>>>
>>> ___ You have too many commits attached to an e-mail; resend as threaded
>>> commits, or place in a public tree for a pull.
>>>
>>> ___ You have resent this content multiple times without a clear indication
>>> of what has changed between each re-send.
>>>
>>> ___ You have failed to adequately and individually address all of the
>>> comments and change requests that were proposed in the initial review.
>>>
>>> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
>>>
>>> ___ Your computer have a badly configured date and time; confusing the
>>> the threaded patch review.
>>>
>>> ___ Your changes affect IPC mechanism, and you don't present any results
>>> for in-service upgradability test.
>>>
>>> ___ Your changes affect user manual and documentation, your patch series
>>> do not contain the patch that updates the Doxygen manual.
>>>
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
