Summary: amfsv: Make Amfnd applier [#517]
Review request for Trac Ticket(s): #517
Peer Reviewer(s): Hans F, Hans N, Ander Bj, Mathi, Praveen
Pull request to:
Affected branch(es): All
Development branch: opensaf-4.3.x
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Please note that this patch is a prototype of making Amfnd as applier.
It only reads component configuration added dynamically.
This works fine for adding amf demo application. Tested unlock-in, unlock,
lock, lock-in.
Please note that modification in avd_su.c is a hack to test addition of amf
demo.
Scope of review : Please check feasibility/performance of doing it at
amf/system level.
Can it create more problem than it solves ?
Further improvements:
1. Need to read SU, SG or modification of SG/SU/Comp.
2. Need to filter SU at node level at amfnd.
3. Need to read configuration at startup.
changeset ac654f30b0f66bb2975668b05baec56b2a665614
Author: Nagendra Kumar<[email protected]>
Date: Mon, 02 Sep 2013 18:46:41 +0530
amfsv: Make Amfnd applier [#517]
Added Files:
------------
osaf/services/saf/avsv/avnd/avnd_imm.c
Complete diffstat:
------------------
osaf/services/saf/avsv/avd/avd_su.c | 4 +-
osaf/services/saf/avsv/avnd/Makefile.am | 1 +
osaf/services/saf/avsv/avnd/avnd.c | 4 +
osaf/services/saf/avsv/avnd/avnd_compdb.c | 2 +-
osaf/services/saf/avsv/avnd/avnd_imm.c | 608
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/services/saf/avsv/avnd/avnd_proc.c | 14 +-
osaf/services/saf/avsv/avnd/avnd_sudb.c | 12 +-
osaf/services/saf/avsv/avnd/include/avnd.h | 1 +
osaf/services/saf/avsv/avnd/include/avnd_cb.h | 2 +
osaf/services/saf/avsv/avnd/include/avnd_comp.h | 2 +
osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +
11 files changed, 645 insertions(+), 7 deletions(-)
Testing Commands:
-----------------
Add Amf demo. Perform unlock-in, unlock, lock-in, lock.
Testing, Expected Results:
--------------------------
Commands works fine.
Conditions of Submission:
-------------------------
Not ready to commit, it is just for prototyping.
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
