Summary: logsv test: Testcases must work with different system configurations Review request for Trac Ticket(s): [#541] Peer Reviewer(s): Madhurika Koppula, Hans Feldt Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>> Development branch: devel (4.4)
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset b9156f00e3de365c0beb3a43abebff32c0997b8f Author: Lennart Lund <[email protected]> Date: Mon, 02 Sep 2013 16:58:16 +0200 logtest: Replace hard coded root path with root path fetched from log service IMM config object [#541] Testcases must work with different system configurations (#541) part 01 changeset afd012be7f673e2d2ec594b97102fbc49a0badde Author: Lennart Lund <[email protected]> Date: Mon, 02 Sep 2013 16:58:22 +0200 logtest: New function for validate in test fm when using external tools e.g. immadm. [#541] Testcases must work with different system configurations (#541) part 02 - Created function aisrc_validate() that will replace test_validate() which is marked as deprecated. - Added function rc_validate() in unit test fw. A variant of existing function test_validate(). changeset f0f60862c2f398ab1f34c11c3997727f6e861aa3 Author: Lennart Lund <[email protected]> Date: Mon, 02 Sep 2013 16:58:26 +0200 logtest: Fix incorrect error print at FAIL [#541] Testcases must work with different system configurations (#541) part 03 - Use rc_validate() when testcase is using an external tool e.g. immadm changeset 4cb0114ecee843edc7c92e35959d029eaee896d1 Author: Lennart Lund <[email protected]> Date: Tue, 03 Sep 2013 09:45:11 +0200 logtest: Comment testcases with description of what is tested [#541] Testcases must work with different system configurations (#541) part 03 - Testcases in tet_logOiOps.c (logtest suite 4) are commented Complete diffstat: ------------------ tests/logsv/Makefile.am | 4 +++- tests/logsv/logtest.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/logsv/logtest.h | 3 ++- tests/logsv/tet_LogOiOps.c | 28 +++++++++++++++++++++++----- tests/unit_test_fw/inc/utest.h | 17 +++++++++++++++++ tests/unit_test_fw/src/utest.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 170 insertions(+), 7 deletions(-) Testing Commands: ----------------- For the following tests it is assumed that OpenSAF UML environment is used: 1. Test normal operation. Path in configobject shall be used # logtest 2. Change root path and test. New root path shall be used # mkdir repl_opensaf/logtest # immcfg -a logRootDirectory=/repl_opensaf/logtest logConfig=1,safApp=safLogService # logtest 3. Check new error printout at FAIL # logtest 4 37 Testing, Expected Results: -------------------------- 1. 114 PASS 0 FAIL. Created files and directories shall be found in repl_opensaf/saflog 2. 114 PASS 0 FAIL. Created files and directories shall be found in repl_opensaf/logtest 3. Suite 4: LOG OI tests saLogStreamOpen_2 FAILED: 12 37 FAILED (expected EXIT_SUCCESS, got EXIT_FAILURE (1)) saflogtest, writing to strB ===================================================================================== Test Result: Total: 1 Passed: 0 Failed: 1 Conditions of Submission: ------------------------- Ack from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
