Summary: remove avd_ file prefix from amfd
Review request for Trac Ticket(s): 533
Peer Reviewer(s): Praveen
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: default

--------------------------------
Impacted area       Impact y/n
--------------------------------
 Docs                    n
 Build system            n
 RPM/packaging           n
 Configuration files     n
 Startup scripts         n
 SAF services            y
 OpenSAF services        n
 Core libraries          n
 Samples                 n
 Tests                   n
 Other                   n


Comments (indicate scope for each "y" above):
---------------------------------------------

changeset 353f1fb74c28a5d2cc4009e071f290f5db249165
Author: Hans Feldt <[email protected]>
Date:   Fri, 06 Sep 2013 12:11:49 +0200

        amfd: move avd.cc contents to avd_proc.cc [#533]

changeset 415332cf84e3743bdec22432a490b1846881db2a
Author: Hans Feldt <[email protected]>
Date:   Fri, 06 Sep 2013 12:11:56 +0200

        amfd: remove avd.cc file [#533]

changeset 2accf19fd806f28a54f9e27eac4ccb9053536921
Author: Hans Feldt <[email protected]>
Date:   Fri, 06 Sep 2013 12:12:00 +0200

        amfd: move amfd_main.cc contents to avd_proc.cc [#533]

changeset 5d04d6aba348a98249d86dfbe3a45988322c3600
Author: Hans Feldt <[email protected]>
Date:   Fri, 06 Sep 2013 12:12:02 +0200

        amfd: remove amfd_main.cc file [#533]

changeset c56f83715925d9a674e96de79c7a8effdad6fb3c
Author: Hans Feldt <[email protected]>
Date:   Fri, 06 Sep 2013 12:12:06 +0200

        amfd: rename avd_proc.cc to main.cc [#533]

changeset 6e922787b697e9cffae8eb8ce095b2727271ac54
Author: Hans Feldt <[email protected]>
Date:   Fri, 06 Sep 2013 12:12:09 +0200

        amfd: main() cleanup [#533]

changeset fd51ec9bed3a174462ebf825a369d91482311284
Author: Hans Feldt <[email protected]>
Date:   Fri, 06 Sep 2013 12:30:31 +0200

        amfd: remove avd_ file prefix [#533]

changeset dfcb64a4a25d897460cfef5d92ef5b02f7e01ae6
Author: Hans Feldt <[email protected]>
Date:   Fri, 06 Sep 2013 12:30:39 +0200

        amfd: remove avd_ header file prefix [#533]


Removed Files:
--------------
 osaf/services/saf/amf/amfd/amfd_main.cc
 osaf/services/saf/amf/amfd/avd.cc
 osaf/services/saf/amf/amfd/include/avd_dl_api.h


Complete diffstat:
------------------
 osaf/services/saf/amf/amfd/Makefile.am             |  102 +++++++++---------
 osaf/services/saf/amf/amfd/amfd_main.cc            |   57 ----------
 osaf/services/saf/amf/amfd/avd_app.cc              |   11 +-
 osaf/services/saf/amf/amfd/avd_apptype.cc          |   10 +-
 osaf/services/saf/amf/amfd/avd.cc                  |  260 
------------------------------------------------
 osaf/services/saf/amf/amfd/avd_chkop.cc            |    2 +-
 osaf/services/saf/amf/amfd/avd_ckpt_dec.cc         |    8 +-
 osaf/services/saf/amf/amfd/avd_ckpt_edu.cc         |    4 +-
 osaf/services/saf/amf/amfd/avd_ckpt_enc.cc         |    6 +-
 osaf/services/saf/amf/amfd/avd_ckpt_updt.cc        |    4 +-
 osaf/services/saf/amf/amfd/avd_clm.cc              |    8 +-
 osaf/services/saf/amf/amfd/avd_cluster.cc          |   10 +-
 osaf/services/saf/amf/amfd/avd_comp.cc             |   14 +-
 osaf/services/saf/amf/amfd/avd_compcstype.cc       |   14 +-
 osaf/services/saf/amf/amfd/avd_comptype.cc         |    4 +-
 osaf/services/saf/amf/amfd/avd_csi.cc              |    8 +-
 osaf/services/saf/amf/amfd/avd_csiattr.cc          |    6 +-
 osaf/services/saf/amf/amfd/avd_cstype.cc           |    6 +-
 osaf/services/saf/amf/amfd/avd_ctcstype.cc         |    4 +-
 osaf/services/saf/amf/amfd/avd_dmsg.cc             |    2 +-
 osaf/services/saf/amf/amfd/avd_hlt.cc              |    6 +-
 osaf/services/saf/amf/amfd/avd_hlttype.cc          |    2 +-
 osaf/services/saf/amf/amfd/avd_imm.cc              |   26 ++--
 osaf/services/saf/amf/amfd/include/Makefile.am     |   58 +++++-----
 osaf/services/saf/amf/amfd/include/avd.h           |   30 ++--
 osaf/services/saf/amf/amfd/include/avd_app.h       |    4 +-
 osaf/services/saf/amf/amfd/include/avd_dl_api.h    |   40 -------
 osaf/services/saf/amf/amfd/include/avd_cb.h        |    4 +-
 osaf/services/saf/amf/amfd/include/avd_ckp.h       |    5 +-
 osaf/services/saf/amf/amfd/include/avd_ckpt_edu.h  |    0 
 osaf/services/saf/amf/amfd/include/avd_ckpt_msg.h  |    0 
 osaf/services/saf/amf/amfd/include/avd_ckpt_updt.h |    0 
 osaf/services/saf/amf/amfd/include/avd_clm.h       |    0 
 osaf/services/saf/amf/amfd/include/avd_cluster.h   |    2 +-
 osaf/services/saf/amf/amfd/include/avd_comp.h      |    2 +-
 osaf/services/saf/amf/amfd/include/avd_csi.h       |    6 +-
 osaf/services/saf/amf/amfd/include/avd_def.h       |    8 -
 osaf/services/saf/amf/amfd/include/avd_evt.h       |    2 +-
 osaf/services/saf/amf/amfd/include/avd_hlt.h       |    0 
 osaf/services/saf/amf/amfd/include/avd_imm.h       |    0 
 osaf/services/saf/amf/amfd/include/avd_mds.h       |    0 
 osaf/services/saf/amf/amfd/include/avd_msg.h       |    0 
 osaf/services/saf/amf/amfd/include/avd_node.h      |    4 +-
 osaf/services/saf/amf/amfd/include/avd_ntf.h       |    4 +-
 osaf/services/saf/amf/amfd/include/avd_pg.h        |    6 +-
 osaf/services/saf/amf/amfd/include/avd_proc.h      |    8 +-
 osaf/services/saf/amf/amfd/include/avd_sg.h        |    4 +-
 osaf/services/saf/amf/amfd/include/avd_si.h        |   10 +-
 osaf/services/saf/amf/amfd/include/avd_si_dep.h    |    4 +-
 osaf/services/saf/amf/amfd/include/avd_su.h        |   12 +-
 osaf/services/saf/amf/amfd/include/avd_susi.h      |    6 +-
 osaf/services/saf/amf/amfd/include/avd_sutype.h    |    2 +-
 osaf/services/saf/amf/amfd/include/avd_tmr.h       |    0 
 osaf/services/saf/amf/amfd/include/avd_util.h      |    2 +-
 osaf/services/saf/amf/amfd/avd_proc.cc             |  449 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------
 osaf/services/saf/amf/amfd/avd_mds.cc              |    4 +-
 osaf/services/saf/amf/amfd/avd_ndfsm.cc            |    4 +-
 osaf/services/saf/amf/amfd/avd_ndmsg.cc            |    2 +-
 osaf/services/saf/amf/amfd/avd_ndproc.cc           |    7 +-
 osaf/services/saf/amf/amfd/avd_node.cc             |    6 +-
 osaf/services/saf/amf/amfd/avd_nodegroup.cc        |    6 +-
 osaf/services/saf/amf/amfd/avd_nodeswbundle.cc     |    6 +-
 osaf/services/saf/amf/amfd/avd_ntf.cc              |    4 +-
 osaf/services/saf/amf/amfd/avd_pg.cc               |    2 +-
 osaf/services/saf/amf/amfd/avd_role.cc             |   14 +-
 osaf/services/saf/amf/amfd/avd_sg.cc               |   20 +-
 osaf/services/saf/amf/amfd/avd_sg2Nfsm.cc          |    8 +-
 osaf/services/saf/amf/amfd/avd_sgNoRfsm.cc         |    4 +-
 osaf/services/saf/amf/amfd/avd_sgNpMfsm.cc         |    4 +-
 osaf/services/saf/amf/amfd/avd_sgNWayfsm.cc        |    4 +-
 osaf/services/saf/amf/amfd/avd_sgNAcvRfsm.cc       |    6 +-
 osaf/services/saf/amf/amfd/avd_sgproc.cc           |   10 +-
 osaf/services/saf/amf/amfd/avd_sgtype.cc           |   16 +-
 osaf/services/saf/amf/amfd/avd_si.cc               |   14 +-
 osaf/services/saf/amf/amfd/avd_siDep.cc            |    8 +-
 osaf/services/saf/amf/amfd/avd_siass.cc            |   12 +-
 osaf/services/saf/amf/amfd/avd_sirankedsu.cc       |    8 +-
 osaf/services/saf/amf/amfd/avd_su.cc               |   12 +-
 osaf/services/saf/amf/amfd/avd_sutcomptype.cc      |    8 +-
 osaf/services/saf/amf/amfd/avd_sutype.cc           |   12 +-
 osaf/services/saf/amf/amfd/avd_svctype.cc          |   14 +-
 osaf/services/saf/amf/amfd/avd_svctypecstypes.cc   |    4 +-
 osaf/services/saf/amf/amfd/avd_tmr.cc              |    2 +-
 osaf/services/saf/amf/amfd/avd_util.cc             |    5 +-
 84 files changed, 648 insertions(+), 824 deletions(-)


Testing Commands:
-----------------
 Build and start opensaf


Testing, Expected Results:
--------------------------
 works


Conditions of Submission:
-------------------------
 ack from Praveen


Arch      Built     Started    Linux distro
-------------------------------------------
mips        n          n
mips64      n          n
x86         n          n
x86_64      y          y        ubuntu13.04
powerpc     n          n
powerpc64   n          n


Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
    that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
    (i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
    Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
    like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
    cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
    too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
    Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
    commits, or place in a public tree for a pull.

___ You have resent this content multiple times without a clear indication
    of what has changed between each re-send.

___ You have failed to adequately and individually address all of the
    comments and change requests that were proposed in the initial review.

___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)

___ Your computer have a badly configured date and time; confusing the
    the threaded patch review.

___ Your changes affect IPC mechanism, and you don't present any results
    for in-service upgradability test.

___ Your changes affect user manual and documentation, your patch series
    do not contain the patch that updates the Doxygen manual.


------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to