Ack, just one comment. I think the file avnd_avnd.c ends up being named avnd.cc. Please change that name to amfnd.cc (for now).
That file is part of the amfnd-amfnd checkpointing files that we should revisit if and how needed. Thanks, Hans On 09/09/2013 09:37 AM, Hans Nordeback wrote: > Summary: amfnd: Convert amfnd to C++ and remove avnd prefix from files [#94] > Review request for Trac Ticket(s): #94 > Peer Reviewer(s): hansf, nagendra, praveen > Pull request to: > Affected branch(es): default > Development branch: default > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> > > changeset 78a5f68a153c0834e3548bb083c852ddce2ea98a > Author: Hans Nordeback <[email protected]> > Date: Mon, 09 Sep 2013 09:34:12 +0200 > > amfnd: Convert amfnd to C++ and remove avnd prefix from files [#94] > > Convert amfnd to C++ and remove avnd prefix from filenames [#94] > > > Added Files: > ------------ > osaf/services/saf/amf/amfnd/main.cc > > > Removed Files: > -------------- > osaf/services/saf/amf/amfnd/amfnd_main.c > osaf/services/saf/amf/amfnd/avnd.c > osaf/services/saf/amf/amfnd/avnd_proc.c > > > Complete diffstat: > ------------------ > osaf/libs/common/amf/include/amf_eduutil.h | 7 + > osaf/libs/common/amf/include/amf_n2avaedu.h | 8 + > osaf/libs/common/amf/include/amf_n2avamsg.h | 8 + > osaf/libs/common/amf/include/amf_nd2ndmsg.h | 7 + > osaf/services/saf/amf/amfnd/Makefile.am | 70 +++--- > osaf/services/saf/amf/amfnd/amfnd_main.c | 64 ----- > osaf/services/saf/amf/amfnd/avnd.c | 629 > ------------------------------------------------------ > osaf/services/saf/amf/amfnd/avnd_avnd.c | 2 +- > osaf/services/saf/amf/amfnd/avnd_proc.c | 315 > --------------------------- > osaf/services/saf/amf/amfnd/avnd_cam.c | 4 +- > osaf/services/saf/amf/amfnd/avnd_cbq.c | 16 +- > osaf/services/saf/amf/amfnd/avnd_chc.c | 8 +- > osaf/services/saf/amf/amfnd/avnd_ckpt_dec.c | 158 ++++++------ > osaf/services/saf/amf/amfnd/avnd_ckpt_edu.c | 18 +- > osaf/services/saf/amf/amfnd/avnd_ckpt_enc.c | 158 ++++++------ > osaf/services/saf/amf/amfnd/avnd_ckpt_updt.c | 0 > osaf/services/saf/amf/amfnd/avnd_clc.c | 28 +- > osaf/services/saf/amf/amfnd/avnd_clm.c | 7 +- > osaf/services/saf/amf/amfnd/avnd_comp.c | 28 +- > osaf/services/saf/amf/amfnd/avnd_compdb.c | 105 ++++---- > osaf/services/saf/amf/amfnd/avnd_cpm.c | 2 +- > osaf/services/saf/amf/amfnd/avnd_di.c | 20 +- > osaf/services/saf/amf/amfnd/avnd_err.c | 36 +- > osaf/services/saf/amf/amfnd/avnd_evt.c | 2 +- > osaf/services/saf/amf/amfnd/avnd_hcdb.c | 18 +- > osaf/services/saf/amf/amfnd/include/avnd_mds.h | 2 +- > osaf/services/saf/amf/amfnd/include/avnd_mon.h | 3 - > osaf/services/saf/amf/amfnd/main.cc | 925 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > osaf/services/saf/amf/amfnd/avnd_mbcsv.c | 22 +- > osaf/services/saf/amf/amfnd/avnd_mds.c | 28 +- > osaf/services/saf/amf/amfnd/avnd_mon.c | 2 + > osaf/services/saf/amf/amfnd/avnd_pg.c | 8 +- > osaf/services/saf/amf/amfnd/avnd_pgdb.c | 8 +- > osaf/services/saf/amf/amfnd/avnd_proxy.c | 10 +- > osaf/services/saf/amf/amfnd/avnd_proxydb.c | 4 +- > osaf/services/saf/amf/amfnd/avnd_sidb.c | 12 +- > osaf/services/saf/amf/amfnd/avnd_su.c | 2 +- > osaf/services/saf/amf/amfnd/avnd_sudb.c | 8 +- > osaf/services/saf/amf/amfnd/avnd_susm.c | 30 +- > osaf/services/saf/amf/amfnd/avnd_term.c | 2 +- > osaf/services/saf/amf/amfnd/avnd_tmr.c | 8 +- > osaf/services/saf/amf/amfnd/avnd_util.c | 6 +- > osaf/services/saf/amf/amfnd/avnd_verify.c | 0 > 43 files changed, 1374 insertions(+), 1424 deletions(-) > > > Testing Commands: > ----------------- > <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> > > > Testing, Expected Results: > -------------------------- > <<PASTE COMMAND OUTPUTS / TEST RESULTS>> > > > Conditions of Submission: > ------------------------- > <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
