Summary: use SCHED_RESET_ON_FORK in daemonize Review request for Trac Ticket(s): 532 (subpart of it) Peer Reviewer(s): Ramesh Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): all Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries y Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 3e76043b2c02758afdb21022f00c885821bd2b9f Author: Hans Feldt <[email protected]> Date: Wed, 18 Sep 2013 11:09:18 +0200 base: use SCHED_RESET_ON_FORK in daemonize [#532] In ncs_os_process_execute_timed() non async signal safe functions are used between fork() and exec(). That can cause undeterministic behaviour in the child and cause problems for AMF to provide service. The amfnd main thread runs with RT scheduling policy and ncs_os_process_execute_timed() needs to guarantee that child processes get normal scheduling policy and not just inherits the callers policy. By adding the SCHED_RESET_ON_FORK option to the sched_setscheduler system call it is guaranteed by the kernel that all child processes gets normal scheduling policy. No matter the policy of the parent process/thread. Complete diffstat: ------------------ osaf/libs/core/common/daemon.c | 23 ++++++++++++++++++----- osaf/libs/core/leap/os_defs.c | 8 -------- 2 files changed, 18 insertions(+), 13 deletions(-) Testing Commands: ----------------- Build and start opensaf Testing, Expected Results: -------------------------- AMF child process have normal scheduling policy Conditions of Submission: ------------------------- Ack from Ramesh Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
