Summary: Amf: Add trace to improve debugging [#111] Review request for Trac Ticket(s): #111 Peer Reviewer(s): Hans F, Hans N, Praveen Pull request to: Affected branch(es): Default Development branch: Default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset af571a662f8dfa19a78b4e8d00d52bfa274ac373 Author: Nagendra Kumar<[email protected]> Date: Mon, 23 Sep 2013 12:02:16 +0530 Amf: Add trace to improve debugging [#111] Complete diffstat: ------------------ osaf/services/saf/amf/amfd/app.cc | 4 ++-- osaf/services/saf/amf/amfd/cluster.cc | 2 ++ osaf/services/saf/amf/amfd/comp.cc | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++++--- osaf/services/saf/amf/amfd/comptype.cc | 23 +++++++++++++++++++---- osaf/services/saf/amf/amfd/csi.cc | 2 ++ osaf/services/saf/amf/amfd/hlt.cc | 4 ++++ osaf/services/saf/amf/amfd/node.cc | 5 ++++- osaf/services/saf/amf/amfd/sg.cc | 24 ++++++++++++++++++++++++ osaf/services/saf/amf/amfd/sgtype.cc | 5 ++++- osaf/services/saf/amf/amfd/si.cc | 2 ++ osaf/services/saf/amf/amfd/si_dep.cc | 2 ++ osaf/services/saf/amf/amfd/su.cc | 2 ++ osaf/services/saf/amf/amfd/sutype.cc | 4 ++++ osaf/services/saf/amf/amfnd/avnd_chc.c | 9 +++++++-- osaf/services/saf/amf/amfnd/avnd_comp.c | 2 ++ osaf/services/saf/amf/amfnd/avnd_di.c | 3 ++- osaf/services/saf/amf/amfnd/avnd_hcdb.c | 2 ++ osaf/services/saf/amf/amfnd/avnd_pg.c | 5 +++-- osaf/services/saf/amf/amfnd/avnd_pgdb.c | 4 +++- 19 files changed, 142 insertions(+), 17 deletions(-) Testing Commands: ----------------- Added traces. Testing, Expected Results: -------------------------- Conditions of Submission: ------------------------- Ack from peers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
