Summary:opensaf:make MDS/TCP as the default opensaf transport[#232]
Review request for Trac Ticket(s): #232
Peer Reviewer(s): Hans & Mathi
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): defualt
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system y
RPM/packaging y
Configuration files y
Startup scripts y
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
Before re-publishing this MDS/TCP the default patch, following has been
addressed compare to previously published patch :
- Fixed some quality issues in TCP to improve performance and stability
(#273,#1799,#1993,#3116,#2707,#3113,#306,#2845,#2875).
- 70 node setup bring up and switchover and fail-over are tested ,test
performance results are close to TIPC.
- Addressed comments give by Hans in previously published patch.
Following are the changes :
1) Now no configuration change required in nodeinit.conf . The nodeinit.conf
contains a single osaf-transport entry ,
in the MDS/TCP case, it calls "osaf-dtm start" and in MDS/TIPC case, it
calls "configure_tipc" ( nid_tipc renamed ).
2) sed command of nodeinit.conf from the opensafd start script is removed .
3) Now all configuration related to osaf-transport consolidated in nid.conf,
such as choosing
MDS transport protocol (TIPC or TCP), when MDS_TRANSPORT is chosen the
TIPC the network interface name configuration
(e.g. eth0/eth1/eth3) and TIPC net-id (e.g. 1234) has to be configured
appropriately.
4) The old nid_tipc script renamed to "configure_tipc" .
5) mds log rotation is moved to nodeinit.conf common "osaf-transport" script .
6) Then dh_monitoring is renamed to "osaf-transport-monitor" to match osaf
prefix.
7) Build options :
i ) OpenSAF Build with Only TCP Binaries & configuration.
By default OpenSAFuses MDS/TCP as messaging protocol. That simplifies
things on Nodes where TIPC is
NOT enabled in kernels .
==================================================================
#./bootstrap.sh
#./configure (TIPC [default=no] )
# make rpm
==================================================================
ii) OpenSAF Build with TCP & TIPC Binaries and with default TCP is
configured
Even though both TCP & TIPC binaries Build , by default OpenSAFconfigured
to uses MDS/TCP as messaging protocol.
If user need to enable TIPC Binaries need to enable and use the feature
MDS/TIPC.
==================================================================
#./bootstrap.sh
#./configure --enable-tipc (TIPC [enable=yes] )
# make rpm
==================================================================
8) Enabling OpenSAF MDS to use TIPC transport protocol :
==============================================================================================
# export MDS_TRANSPORT=TIPC or Change MDS_TRANSPORT to "TIPC" in
"nid.conf" file
# Change TIPC_ETH_IF to your network interface name, e.g. eth3
# Change TIPC_NET_ID to your TIPC net-id ,e.g 4711
==============================================================================================
9) OPENSAF_MANAGE_TIPC check has been introduced in "osaf-transport" before
invoking nid_tipc.sh (new name "configure_tipc start" )
when acting upon insmod/rmmod of TIPC ,to fulfill OPENSAF_MANAGE_TIPC="no"
functionality complete (flag ) .
10) Updated README ,INSTALL, 00-README.conf & 00-README.debug accordingly.
11) As an impact of point 3 , The Online installation SMF script has to
customized backup and restore of TIPC Network interface name
and TIPC net-id from nodeinit.conf to nid.conf as a process of upgrade.
changeset 43bd9a5cccce0cebf5da23f2581b4dc0514d1597
Author: A V Mahesh <[email protected]>
Date: Thu, 26 Sep 2013 09:17:15 +0530
opensaf:make MDS/TCP as the default opensaf transport[#232]
changeset df919d8ea0ae1bc071d1fc37e8eb76415175c1af
Author: A V Mahesh <[email protected]>
Date: Thu, 26 Sep 2013 09:18:11 +0530
opensaf:changes to README for MDS/TCP as the default transport[#232]
Complete diffstat:
------------------
00-README.conf | 81
++++++++++++++++++-----------
00-README.debug | 75
+++++++++++++++++++-------
INSTALL | 6 +-
README | 41
++++++--------
configure.ac | 11 ++-
opensaf.spec.in | 18
+----
osaf/libs/core/mds/mds_main.c | 43
++++++++-------
osaf/services/infrastructure/dtms/dtm/dtm_main.c | 6 +-
osaf/services/infrastructure/dtms/scripts/Makefile.am | 3 +-
osaf/services/infrastructure/dtms/scripts/dh_monitoring.in | 28
----------
osaf/services/infrastructure/dtms/scripts/osaf-dtm.in | 7 +--
osaf/services/infrastructure/dtms/scripts/osaf-transport-monitor.in | 87
+++++++++++++++++++++++++++++++
osaf/services/infrastructure/dtms/scripts/osaf-transport.in | 173
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/services/infrastructure/nid/config/Makefile.am | 5 -
osaf/services/infrastructure/nid/config/nid.conf | 10 +++-
osaf/services/infrastructure/nid/config/nodeinit.conf.controller | 3 +-
osaf/services/infrastructure/nid/config/nodeinit.conf.payload | 3 +-
osaf/services/infrastructure/nid/scripts/Makefile.am | 2 +-
osaf/services/infrastructure/nid/scripts/configure_tipc.in | 211
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
osaf/services/infrastructure/nid/scripts/nid_tipc.in | 225
---------------------------------------------------------------------------------
osaf/services/infrastructure/nid/scripts/opensafd.in | 30
+---------
osaf/services/saf/immsv/README | 2 +-
22 files changed, 655 insertions(+), 415 deletions(-)
Testing Commands:
-----------------
Bring up Opensaf
Testing, Expected Results:
--------------------------
Opensaf should come-up with MDS/TCP s the default transport
Conditions of Submission:
-------------------------
Ack form Hans & Mathi
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
