Summary: logsv: Add support for admin op result strings [#576]
Review request for Trac Ticket(s): #576
Peer Reviewer(s): Mathi N, Hans F, Anders B
Pull request to: NA
Affected branch(es): 4.4.x
Development branch: devel
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 534ab1ee674b2b65fcaf5528c9fb1003e9a92013
Author: Lennart Lund <lennart.l...@ericsson.com>
Date: Tue, 08 Oct 2013 16:19:43 +0200
logsv: Add support for admin op result strings [#576]
- Replace saImmOiAdminOperationResult() with
saImmOiAdminOperationResult_o2() Remove LOG_ER. Reuse error messages.
- For test purpose, add possibility to create log stream with runtime
IMM
object and keep it open in test tool saflogtest. See ...test/logsv. For
more info use saflogtest -h
Complete diffstat:
------------------
osaf/services/saf/logsv/lgs/lgs_imm.c | 61
+++++++++++++++++++++++++++++++++++++++++++++++++------------
tests/logsv/saflogtest.c | 13 ++++++++++++-
2 files changed, 61 insertions(+), 13 deletions(-)
Testing Commands:
-----------------
Note: Build with --enable-tests
For creating aan application stream with runtime IMM object.
Use following command on one node e.g. SC-2. Will not exit.
> saflogtest -o -a logtst "logtst msg 1"
On other node e.g. SC-1
1.
> immadm -o 1 -p saLogStreamSeverityFilter:SA_UINT32_T:7 safLgStr=logtst
2.
>
immadm -o 2 -p saLogStreamSeverityFilter:SA_UINT32_T:7 safLgStr=logtst
In the same way also incorrect attribute name, incorrect parameter type and
incorrect value (>127) be tested.
Testing, Expected Results:
--------------------------
1. Shall work Ok. No error messages
2. Shall return error messages because of invalid operation ID
error - saImmOmAdminOperationInvoke_2 admin-op RETURNED:
SA_AIS_ERR_INVALID_PARAM (7)
error-string: Invalid operation ID, should be 1 (one) for change filter
>
Conditions of Submission:
-------------------------
Ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
